938435 - Use mozinstall for installing b2g desktop builds in gaia-ui-tests script

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

The gaia-ui-tests on OSX are failing because the install() method doesn't know how to handle .dmg files.  We should use mozinstall() for this (via mozharness' install() method), assuming we can pass it a custom app name ('b2g' vs 'firefox').

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Use mozinstall for installing b2g desktop builds,

This allows us to use mozinstall to install b2g desktop builds, which should fix gaia-ui-tests on osx on cedar.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8338971 [details] [diff] [review]
Use mozinstall for installing b2g desktop builds,

Review of attachment 8338971 [details] [diff] [review]:
-----------------------------------------------------------------

I'm assuming that super(MarionetteTest, self).install() uses mozinstall? Hard to tell if adding 'application': 'b2g' to the config is risky for other jobs that use this script or not, when this lands we should keep an eye on cedar just in case.

Comment 3

[Jonathan Griffin (:jgriffin)]

(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Comment on attachment 8338971 [details] [diff] [review]
> Use mozinstall for installing b2g desktop builds,
> 
> Review of attachment 8338971 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm assuming that super(MarionetteTest, self).install() uses mozinstall?
> Hard to tell if adding 'application': 'b2g' to the config is risky for other
> jobs that use this script or not, when this lands we should keep an eye on
> cedar just in case.

Bah, you're right, I need to make application a config file variable.

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: Use mozinstall for installing b2g desktop builds,

Move application to a config file variable and set it to 'b2g' for gaiatest; it will be None for other tests, which will work for the desktop Firefox case.

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8341222 [details] [diff] [review]
Use mozinstall for installing b2g desktop builds,

Review of attachment 8341222 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8341222 [details] [diff] [review]
Use mozinstall for installing b2g desktop builds,

Review of attachment 8341222 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/mozharness/rev/da4e1979187e

Comment 7

[[e-mail] (:bhearsum)]

In production.