Closed
Bug 938466
Opened 11 years ago
Closed 11 years ago
B2G STK： Correct BIP command const.
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gwang, Assigned: gwang)
References
Details
Attachments
(4 files, 4 obsolete files)
|
1.42 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
|
2.46 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
|
3.07 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.28 KB,
patch
|
Details | Diff | Splinter Review |
From TS 102.223.
OPEN_CHANNEL, CLOSE_CHANNEL, SEND_DATA, RECEIVE_DATA should be 0x40~0x43
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → gwang
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #832043 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #832044 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #832048 -
Flags: review?(allstars.chh)
Blocks: 908536
Blocks: 908535
|
|
Assignee | |
Comment 5•11 years ago
|
||
Update UUID due to IDL change.
Attachment #832043 -
Attachment is obsolete: true
Attachment #832043 -
Flags: review?(allstars.chh)
Attachment #832122 -
Flags: review?(allstars.chh)
Attachment #832122 -
Flags: review?(htsai)
Attachment #832122 -
Flags: review?(allstars.chh)
Attachment #832122 -
Flags: review+
Attachment #832044 -
Flags: review?(allstars.chh) → review+
Attachment #832048 -
Flags: review?(allstars.chh) → review+
Please also provide the marionette test here.
|
|
Assignee | |
Comment 8•11 years ago
|
||
|
|
Assignee | |
Comment 9•11 years ago
|
||
TRY：https://tbpl.mozilla.org/?tree=Try&rev=92d636874add
Part4 patch is parent of 241ed058b5ba.
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8333620 -
Flags: review?(allstars.chh)
Comment on attachment 8333620 [details] [diff] [review]
Part4: STK Marionette test for BIP commands
Review of attachment 8333620 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/icc/tests/marionette/test_stk_bip_command.js
@@ +15,5 @@
> +let tests = [
> + {command: "d04b81030140018202818205074f70656e204944350702030403041f0239020578470a065465737447700272730d08f4557365724c6f670d08f4557365725077643c0301ad9c3e052101010101",
> + func: testBipCommand,
> + expect: {name: "open_channel_1",
> + id: icc.STK_CMD_OPEN_CHANNEL,
s/id/typeOfCommand/
Attachment #8333620 -
Flags: review?(allstars.chh) → review+
|
|
Assignee | |
Comment 11•11 years ago
|
||
id => typeOfCommand
Attachment #8333620 -
Attachment is obsolete: true
|
||
Comment 12•11 years ago
|
||
Comment on attachment 832122 [details] [diff] [review]
Part1: Correct STK BIP command ID.
Review of attachment 832122 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the delay. r=me, thanks.
Attachment #832122 -
Flags: review?(htsai) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
|
Assignee | |
Comment 13•11 years ago
|
||
TRY: https://tbpl.mozilla.org/?tree=Try&rev=8d64009a58a6
**Bug938466's patches are parents of Bug908554**
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 14•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/3436989a306e
https://hg.mozilla.org/integration/b2g-inbound/rev/8ef36d96a366
https://hg.mozilla.org/integration/b2g-inbound/rev/abf315caa163
https://hg.mozilla.org/integration/b2g-inbound/rev/274255d4107d
Flags: in-testsuite+
Keywords: checkin-needed
|
||
Comment 15•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5][Back 2-Dec] from comment #14)
> https://hg.mozilla.org/integration/b2g-inbound/rev/3436989a306e
> https://hg.mozilla.org/integration/b2g-inbound/rev/8ef36d96a366
> https://hg.mozilla.org/integration/b2g-inbound/rev/abf315caa163
> https://hg.mozilla.org/integration/b2g-inbound/rev/274255d4107d
had to backout this changes in https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=5fb0bc84d787 since they caused a bustage in marionette webapi tests like https://tbpl.mozilla.org/php/getParsedLog.php?id=31145533&tree=B2g-Inbound
Flags: in-testsuite+ → in-testsuite?
|
|
Assignee | |
Comment 16•11 years ago
|
||
Modify marionette constant base on Bug 814637.
Attachment #8335874 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 18•11 years ago
|
||
Rebase and TRY: https://tbpl.mozilla.org/?tree=Try&rev=0673dfa8a866
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
|
||
Comment 20•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fe370ca58211
https://hg.mozilla.org/mozilla-central/rev/c53785643cd7
https://hg.mozilla.org/mozilla-central/rev/076abc5a0b30
https://hg.mozilla.org/mozilla-central/rev/d48acf20fb1b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•