Closed Bug 938466 Opened 8 years ago Closed 8 years ago

B2G STK: Correct BIP command const.

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gwang, Assigned: gwang)

References

Details

Attachments

(4 files, 4 obsolete files)

From TS 102.223.
OPEN_CHANNEL, CLOSE_CHANNEL, SEND_DATA, RECEIVE_DATA should be 0x40~0x43
Assignee: nobody → gwang
Status: NEW → ASSIGNED
Blocks: b2g-stk
Attachment #832043 - Flags: review?(allstars.chh)
Attachment #832044 - Flags: review?(allstars.chh)
Attachment #832048 - Flags: review?(allstars.chh)
Update UUID due to IDL change.
Attachment #832043 - Attachment is obsolete: true
Attachment #832043 - Flags: review?(allstars.chh)
Attachment #832122 - Flags: review?(allstars.chh)
Blocks: 908554
Attachment #832122 - Flags: review?(htsai)
Attachment #832122 - Flags: review?(allstars.chh)
Attachment #832122 - Flags: review+
Attachment #832044 - Flags: review?(allstars.chh) → review+
Attachment #832048 - Flags: review?(allstars.chh) → review+
Please also provide the marionette test here.
TRY:https://tbpl.mozilla.org/?tree=Try&rev=92d636874add
Part4 patch is parent of 241ed058b5ba.
Attachment #8333620 - Flags: review?(allstars.chh)
Comment on attachment 8333620 [details] [diff] [review]
Part4: STK Marionette test for BIP commands

Review of attachment 8333620 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/tests/marionette/test_stk_bip_command.js
@@ +15,5 @@
> +let tests = [
> +  {command: "d04b81030140018202818205074f70656e204944350702030403041f0239020578470a065465737447700272730d08f4557365724c6f670d08f4557365725077643c0301ad9c3e052101010101",
> +   func: testBipCommand,
> +   expect: {name: "open_channel_1",
> +            id: icc.STK_CMD_OPEN_CHANNEL,

s/id/typeOfCommand/
Attachment #8333620 - Flags: review?(allstars.chh) → review+
id => typeOfCommand
Attachment #8333620 - Attachment is obsolete: true
Comment on attachment 832122 [details] [diff] [review]
Part1: Correct STK BIP command ID.

Review of attachment 832122 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. r=me, thanks.
Attachment #832122 - Flags: review?(htsai) → review+
Keywords: checkin-needed
TRY: https://tbpl.mozilla.org/?tree=Try&rev=8d64009a58a6
**Bug938466's patches are parents of Bug908554**
Keywords: checkin-needed
Modify marionette constant base on Bug 814637.
Attachment #8335874 - Attachment is obsolete: true
Update UUID.
Attachment #832122 - Attachment is obsolete: true
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.