938581 - if nsIZipReader.open fails in chrome-harness, fail test immediately rather than time out

Status: NEW

(Testing :: Mochitest, defect)

Description

[Andrew McCreight [:mccr8]]

I'm not sure exactly how this should work, but in bug 920978, the chrome harness tries to open something with the zip reader, and fails:

13:53:30  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_dragdrop.js | uncaught exception - NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIZipReader.open] at chrome://mochikit/content/chrome-harness.js:271

Rather than just failing the test immediately (I can't see how it could possible succeed at that point), it ends up timing out a minute later.

This doesn't seem like a huge deal, as TBPL does correctly show that the open failure is the real underlying problem, and a minute isn't that long in the scheme of things.

Comment 1

[(not currently active) Ted Mielczarek]

Is this just a symptom of our "JS errors don't cause test failure" problem?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I suppose so; that's loosely covered by bug 920191.