Closed Bug 938626 Opened 8 years ago Closed 8 years ago
Make pref changes a bit safer in Pres
PreferenceChanged may end up causing reflows and what not, yet we have only raw refs to objects. It also calls AppUnitsPerDevPixelChanged after possible reflow, so mDeviceContext can be null. This may fix Bug 891840.
Attachment #832278 - Flags: review?
Attachment #832278 - Flags: review? → review?(tnikkel)
Attachment #832278 - Flags: review?(tnikkel) → review+
I haven't actually found any problematic cases except when tests use privileged JS to set the prefs. So this should be safe to land.
I don't think this needs QA verification. If anyone thinks that's a mistake please remove the [qa-] whiteboard tag and add the verifyme keyword.
You need to log in before you can comment on or make changes to this bug.