Closed
Bug 938626
Opened 11 years ago
Closed 11 years ago
Make pref changes a bit safer in PresContext
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: smaug, Assigned: smaug)
Details
(Keywords: sec-want, Whiteboard: [qa-][adv-main28+])
Attachments
(1 file)
|
2.34 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
PreferenceChanged may end up causing reflows and what not, yet we have only
raw refs to objects.
It also calls AppUnitsPerDevPixelChanged after possible reflow, so mDeviceContext
can be null.
This may fix Bug 891840.
Attachment #832278 -
Flags: review?
|
Assignee | |
Updated•11 years ago
|
Group: layout-core-security → core-security
|
|
Assignee | |
Updated•11 years ago
|
Attachment #832278 -
Flags: review? → review?(tnikkel)
|
||
Updated•11 years ago
|
Attachment #832278 -
Flags: review?(tnikkel) → review+
|
|
Assignee | |
Comment 1•11 years ago
|
||
I haven't actually found any problematic cases except when tests use privileged JS to
set the prefs.
So this should be safe to land.
|
||
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox28:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
I don't think this needs QA verification. If anyone thinks that's a mistake please remove the [qa-] whiteboard tag and add the verifyme keyword.
Whiteboard: [qa-]
|
||
Updated•11 years ago
|
status-firefox27:
--- → wontfix
Whiteboard: [qa-] → [qa-][adv-main28+]
|
|
||
Updated•10 years ago
|
Group: core-security
You need to log in
before you can comment on or make changes to this bug.
Description
•