Closed Bug 938626 Opened 7 years ago Closed 7 years ago

Make pref changes a bit safer in PresContext

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox-esr24 --- wontfix
b2g18 --- wontfix
b2g-v1.2 --- wontfix

People

(Reporter: smaug, Assigned: smaug)

Details

(Keywords: sec-want, Whiteboard: [qa-][adv-main28+])

Attachments

(1 file)

PreferenceChanged may end up causing reflows and what not, yet we have only
raw refs to objects.
It also calls AppUnitsPerDevPixelChanged after possible reflow, so mDeviceContext
can be null.

This may fix Bug 891840.
Attachment #832278 - Flags: review?
Group: layout-core-security → core-security
Attachment #832278 - Flags: review? → review?(tnikkel)
Attachment #832278 - Flags: review?(tnikkel) → review+
I haven't actually found any problematic cases except when tests use privileged JS to
set the prefs.
So this should be safe to land.
Keywords: sec-want
https://hg.mozilla.org/mozilla-central/rev/78a02007f383
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
I don't think this needs QA verification. If anyone thinks that's a mistake please remove the [qa-] whiteboard tag and add the verifyme keyword.
Whiteboard: [qa-]
Whiteboard: [qa-] → [qa-][adv-main28+]
Group: core-security
You need to log in before you can comment on or make changes to this bug.