938627 - GetPCCountJSON text line numbers do not always match opcode line numbers

Status: NEW

(Core :: JavaScript Engine, enhancement, P3)

Description

[Dan Minor [:dminor]]

The text field in the JSON string created by GetPCCountJSON is created by calling JS_DecompileScript which in some circumstances will insert "use strict" into the text. If this text is then split into lines, the line numbers will not correspond with the line numbers in the opcodes.

I can work around this, but it would be more convienent if they did match. I could remove "use strict" from the text in this case or add an offset to the opcode line numbers. I'd be happy to put together a patch, but was wondering if there was a preferred way of handling this.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Hmm. If we could reproduce this still, it would definitely be worth fixing.