938939 - Fix SVGContentUtils::ParseInteger documentation about numbers that cannot be represented by an int32_t

Status: RESOLVED FIXED

(Core :: SVG, defect, P5)

Description

[Daniel Holbert [:dholbert]]

While reviewing bug 937614, I noticed that the comment...
> 170    * Parsing fails if the number cannot be represented by an int32_t.
...documentation for SVGContentUtils::ParseInteger() isn't actually correct.

MXR link:
http://mxr.mozilla.org/mozilla-central/source/content/svg/content/src/SVGContentUtils.h#170
http://mxr.mozilla.org/mozilla-central/source/content/svg/content/src/SVGContentUtils.cpp#553

We only fail if we encounter a non-digit character. For values outside of the numeric limits for an int32_t, we clamp and return true. We should update the documentation to indicate that.

(This comment used to be correct, but we changed the behavior in bug 919319 comment 9.)

(Note that this affects the new version of ParseInteger introduced in bug 937614, too.)

Comment 1

[Daniel Holbert [:dholbert]]

(holding off on fixing this to avoid bitrotting bug 937614, BTW.)

Comment 2

[Robert Longson [:longsonr]]

Are you sure you don't want me to just fold this into bug 937614?

Comment 3

[Daniel Holbert [:dholbert]]

Feel free, if you'd like!

Comment 4

[Daniel Holbert [:dholbert]]

(I didn't mention it there because it was an existing, only tangentially related thing, and I didn't want to pile on too many things to that bug.)

(More review comments coming over there soon. :))

Comment 5

[Robert Longson [:longsonr]]

Fixed by checkin for bug 937614