938950 - Don't provide full access to compartment/zone/runtime when compiling off thread

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

When compiling off thread bare pointers to the compartment, zone and runtime can be obtained which could allow for non-threadsafe accesses to occur.  These accesses can happen through either the compartment member of MIRGenerator/IonBuilder, or through TLS with GetIonContext.  It would be nicer if these only provided interfaces for accessing the compartment/zone/runtime in threadsafe ways, mostly for obtaining the address of various internal bits of the system.  The attached patch adds Compile{Compartment,Zone,Runtime} classes for this purpose.

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 832685 [details] [diff] [review]
patch

Review of attachment 832685 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!

::: js/src/jit/CompileWrappers.h
@@ +26,5 @@
> +{
> +    JSRuntime *runtime();
> +
> +public:
> +

Nit: indentation and extra blank line.

Comment 2

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aacbc603eb67

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/51b8979e2dd6 for breaking the build everywhere: https://tbpl.mozilla.org/php/getParsedLog.php?id=30715762&tree=Mozilla-Inbound

Comment 4

[Brian Hackett [Laid off!]]

Ugh, using hg patch didn't actually hg add the new files in the patch.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c848ede03acc

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And back out again  https://hg.mozilla.org/integration/mozilla-inbound/rev/6a77bea7ccaa
https://tbpl.mozilla.org/php/getParsedLog.php?id=30719043&tree=Mozilla-Inbound

Comment 6

[Brian Hackett [Laid off!]]

I guess our build system is now so stupid that adding new source files requires a clobber.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4df4f9fff8c5

Comment 7

[Andrew McCreight [:mccr8]]

I filed bug 940404 for that clobber-needing.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4df4f9fff8c5
https://hg.mozilla.org/mozilla-central/rev/ddf925dab861