939122 - Toolkit code references chrome locales (breaks with Firefox OS)

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Paul Rouget [:paul]]

When using the inspector with Firefox OS, we see:

I/Gecko   (  909):   Message: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/styleinspector/css-logic.js :: CssLogic.l10n :: line 730"  data: no]

This is because of:

>  XPCOMUtils.defineLazyGetter(CssLogic, "_strings", function() Services.strings
>          .createBundle("chrome://browser/locale/devtools/styleinspector.properties"));

styleinspector.properties needs to be moved to /toolkit/

Comment 1

[Paul Rouget [:paul]]

Mike, if you don't mind, I'll take that. It's blocking me.

Comment 2

[Paul Rouget [:paul]]

Attachment: patch.diff

Comment 3

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=901829e7a9a5

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8333770 [details] [diff] [review]
patch.diff

Review of attachment 8333770 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine and I wouldn't expect any issues on try.

r+

Comment 5

[Paul Rouget [:paul]]

Suspicious orange. Repushing: https://tbpl.mozilla.org/?tree=Try&rev=ac5f7f8793f4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/400b95c3beeb

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/400b95c3beeb