Closed Bug 939122 Opened 6 years ago Closed 6 years ago

Toolkit code references chrome locales (breaks with Firefox OS)

Categories

(DevTools :: Inspector, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: paul, Assigned: paul)

Details

Attachments

(1 file)

When using the inspector with Firefox OS, we see:

I/Gecko   (  909):   Message: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/styleinspector/css-logic.js :: CssLogic.l10n :: line 730"  data: no]

This is because of:

>  XPCOMUtils.defineLazyGetter(CssLogic, "_strings", function() Services.strings
>          .createBundle("chrome://browser/locale/devtools/styleinspector.properties"));

styleinspector.properties needs to be moved to /toolkit/
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Mike, if you don't mind, I'll take that. It's blocking me.
Assignee: mratcliffe → paul
Attached patch patch.diffSplinter Review
Attachment #8333770 - Flags: review?(mratcliffe)
Comment on attachment 8333770 [details] [diff] [review]
patch.diff

Review of attachment 8333770 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine and I wouldn't expect any issues on try.

r+
Attachment #8333770 - Flags: review?(mratcliffe) → review+
Suspicious orange. Repushing: https://tbpl.mozilla.org/?tree=Try&rev=ac5f7f8793f4
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/400b95c3beeb
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/400b95c3beeb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.