Closed
Bug 939147
Opened 13 years ago
Closed 12 years ago
[Action Icons - Browser] Remove shadows from action icons
Categories
(Firefox OS Graveyard :: Gaia::Browser, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: amylee, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, jian)
Attachments
(2 files, 1 external file)
Hi Pavel,
Please replace the action icons in this app with the ones that I'll be providing (I'll be attaching new icons to this bug). This is a blocker for Bug 939106.
Thanks!
Comment 1•13 years ago
|
||
Hi Pavel,
Here are the browser icons, I've replaced them within the folder structure
gaia/apps/browser...
Thanks!
| Assignee | ||
Comment 2•13 years ago
|
||
Attachment #8333693 -
Flags: feedback?(epang)
Comment 3•12 years ago
|
||
Hey Pavel, while checking the patch I noticed I missed a image, sorry!
can you swap out refresh.png with the one attached?
Also search.png and refresh.png seem to be stretched, they should be 27x27 on SD
and 40x40 on HD WVGA
Thanks!
| Assignee | ||
Comment 4•12 years ago
|
||
Done :)
Comment 5•12 years ago
|
||
Comment on attachment 8333693 [details] [review]
patch for Gaia/master
Looks good, ready for review! Thanks :)
Attachment #8333693 -
Flags: feedback?(epang) → feedback+
| Assignee | ||
Updated•12 years ago
|
Attachment #8333693 -
Flags: review?(dale)
Comment 6•12 years ago
|
||
Comment on attachment 8333693 [details] [review]
patch for Gaia/master
are https://github.com/pivanov/gaia/blob/95a0701ad4cab07454336dca6d8ecc0d440a26d6/apps/browser/style/images/site_security_broken.png and https://github.com/pivanov/gaia/blob/95a0701ad4cab07454336dca6d8ecc0d440a26d6/apps/browser/style/images/site_security_broken%401.5x.png
Supposed to be different? (if so thats fine, but assuming its a mistake)
Also there are file mode changes in this commit that there shouldnt be (https://github.com/pivanov/gaia/blob/95a0701ad4cab07454336dca6d8ecc0d440a26d6/apps/browser/style/images/crashed-tab-icon.png + https://github.com/pivanov/gaia/blob/95a0701ad4cab07454336dca6d8ecc0d440a26d6/apps/browser/style/images/site_security_broken.png + https://github.com/pivanov/gaia/blob/95a0701ad4cab07454336dca6d8ecc0d440a26d6/apps/browser/style/images/site_security_verified.png)
And as a nit, would prefer an untagged commit message
"Bug 939147 - Remove shadows from browser action icons"
Can land with at least the second 2 fixed, cheers (if you need me to land just needinfo me when you up the ammended commit)
Attachment #8333693 -
Flags: review?(dale) → review+
| Assignee | ||
Comment 7•12 years ago
|
||
Hey Dale,
thanks for the review, I fixed the mistakes
Landed in master,
https://github.com/mozilla-b2g/gaia/commit/455f56255eed58e7b7c1a06e611fd56c44afdc42
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•