939166 - Clean up script global acquisition in CallSetup

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

We do a bunch of QIs right now that aren't actually necessary. I can make this stuff quite a bit faster and simpler. :-)

Comment 1

[Bobby Holley (:bholley)]

Attachment: Part 1 - Be more direct in GetStaticScriptGlobal. v1

This can all collapse because of the following facts:
* Ever since we introduced SandboxPrivate, we never actually use a Window
  as an SOP for a sandbox.
* nsGlobalWindow is actually the only thing that implements nsIScriptGlobalObject.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 2 - Stop going through nsIScriptGlobalObject in CallSetup. v2

Comment 3

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=ccda52583589

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8335080 [details] [diff] [review]
Part 1 - Be more direct in GetStaticScriptGlobal. v1

Hrm.  We sure used to have code that depended on finding the window via this codepath for sandboxes!  I guess maybe it doesn't anymore.

>+    // This assumes that we only have WN window globals.

Can we just GetISupportsFromJSObject our way to victory here?  Though we'd then need to deal with the nsISupports maybe pointing to an XPCWrappedNative*...

Basically, I'd rather we didn't add pitfalls here for the Window conversion to webidl.

r=me with that fixed.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8335081 [details] [diff] [review]
Part 2 - Stop going through nsIScriptGlobalObject in CallSetup. v2

r=me

Comment 6

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=d4db32c65f49

Comment 7

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c8e22393c137
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/181e285a7d51

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c8e22393c137
https://hg.mozilla.org/mozilla-central/rev/181e285a7d51