939191 - FirefoxOS scrolling FPS test appears to be broken

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect, P1)

Description

[William Lachance (:wlach)]

So we're not measuring fps very well on FirefoxOS, that's a known problem.

However, with the settings app, we have the additional problem that it's not working as intended. It's supposed to be scrolling continually, but what we're seeing instead is a bit of movement followed by nothing. We should fix it.

Example of bad behaviour:

http://people.mozilla.org/~dhunt/eideticker-ci-dashboard/b2g.inari.mozilla-central.master.tests/framediff-view.html?title=Frame%20Difference%20FirefoxOS%20Settings%20Scrolling%20Performance%20%282013-11-12%29&video=videos/video-1384268771.71.webm&framediff=framediffs/framediff-1384268781.05.json&actionlog=actionlogs/action-log-1384268781.05.json

Comment 1

[William Lachance (:wlach)]

Working on this. The problem is that we're trying to scroll around the area of the header, which doesn't work at all. I'm probably going to use a similar strategy as we did with the callog test: get actual dimensions of settings content area, then scroll that.

Comment 2

[William Lachance (:wlach)]

Attachment: 0001-Bug-939191-Fix-settings-scrolling-test-r-davehunt.patch

Using a similar method to what we used in the callog scrolling test. Seems to work pretty ok.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8334935 [details] [diff] [review]
0001-Bug-939191-Fix-settings-scrolling-test-r-davehunt.patch

Review of attachment 8334935 [details] [diff] [review]:
-----------------------------------------------------------------

Works well. With the debugging removed r=me.

::: src/tests/b2g/appscrolling/settings.py
@@ +7,5 @@
> +        settings_container = self.device.marionette.find_element(
> +            By.CSS_SELECTOR, '#root > div')
> +        settings_location = settings_container.location
> +        settings_swipe_padding = 16
> +        print settings_container.location

I'm guessing these are left over from debugging?

@@ +14,5 @@
> +        scroll_x1 = settings_location['x'] + settings_container.size['width'] / 2
> +        scroll_y1 = settings_location['y'] + (settings_container.size['height'] -
> +                                              settings_swipe_padding)
> +        scroll_y2 = settings_location['y'] + settings_swipe_padding
> +        print (scroll_x1, scroll_y1, scroll_y2)

Also debugging?

Comment 4

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/eideticker/commit/fb7e374c1db4e342ffa3156d0a6bccf78069bd9a