Closed
Bug 939222
Opened 12 years ago
Closed 12 years ago
[Action Icons - Video] Remove shadows from action icons
Categories
(Firefox OS Graveyard :: Gaia::Video, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, jian)
Attachments
(4 files, 1 external file, 1 obsolete file)
play@1.5x.png
Hi Pavel,
Please update the icons with the attached.
Thanks!
|
Reporter | |
Comment 1•12 years ago
|
||
Hi Pavel,
Here are the video icons, I've replaced them within the folder structure
gaia/apps/video...
Thanks!
|
|
Reporter | |
Updated•12 years ago
|
Attachment #833065 -
Attachment is obsolete: true
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #8338886 -
Flags: review?(epang)
|
|
Reporter | |
Comment 3•12 years ago
|
||
Hey Pavel, looks like we need to replace one of the icons. Thanks!
Flags: needinfo?(pivanov)
|
|
Reporter | |
Comment 5•12 years ago
|
||
sorry more replacement. The play icon should be 30x30 (not 40x40). thanks!
Flags: needinfo?(epang) → needinfo?(pivanov)
|
|
Reporter | |
Comment 7•12 years ago
|
||
Hey Pavel,
The play button looks really bug, but I'm pretty sure the icon is sized correctly.
Can you take a look? Will this be fixed with the video player update bug?
Thanks!
Flags: needinfo?(pivanov)
|
|
Assignee | |
Comment 8•12 years ago
|
||
PR updated, sorry I fixed this but I forgot to update the PR
Flags: needinfo?(pivanov)
|
|
Reporter | |
Comment 9•12 years ago
|
||
Comment on attachment 8338886 [details] [review]
patch for Gaia/master
Looks good, thanks! let's land this :)
Attachment #8338886 -
Flags: review?(epang) → review+
|
|
Assignee | |
Comment 10•12 years ago
|
||
Landed to master:
https://github.com/mozilla-b2g/gaia/commit/6407e76986285e3f9177ba4a4f75666a019e3c0b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•