Closed
Bug 939224
Opened 13 years ago
Closed 12 years ago
[Action Icons - Notification Tray] Remove shadows from action icons
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, jian)
Attachments
(2 files, 1 external file, 1 obsolete file)
Hi Pavel,
Please update the icons with the attached.
Thanks!
| Reporter | ||
Comment 1•13 years ago
|
||
Hey Pavel,
I couldn't find where this setting icon was on gaia. I've attached a screen showing the setting icon I'm referring too. I've also attached the icon, can you help swap it out? Thanks!
Attachment #833068 -
Attachment is obsolete: true
Flags: needinfo?(pivanov)
| Assignee | ||
Comment 2•13 years ago
|
||
Sure ... here is the patch
Attachment #8333977 -
Flags: feedback?(epang)
Flags: needinfo?(pivanov)
| Reporter | ||
Comment 3•13 years ago
|
||
Sorry, I didn't realize the pressed state if this icon had a drop shadow. Attached all the icons again, including the pressed state. Thanks!
Flags: needinfo?(pivanov)
| Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 8333977 [details] [review]
patch for Gaia/master
Looks good now, Thanks Pavel. Review time :)
Attachment #8333977 -
Flags: feedback?(epang) → feedback+
| Assignee | ||
Updated•13 years ago
|
Attachment #8333977 -
Flags: review?(kaze)
| Reporter | ||
Comment 5•12 years ago
|
||
Comment on attachment 8333977 [details] [review]
patch for Gaia/master
Hi Vivien, can you help review this patch? Thanks!
Attachment #8333977 -
Flags: review?(kaze) → review?(21)
Comment 6•12 years ago
|
||
Comment on attachment 8333977 [details] [review]
patch for Gaia/master
Please re-ping Vivien for the review if my r+ is not enough.
Attachment #8333977 -
Flags: review?(21) → review+
| Assignee | ||
Comment 7•12 years ago
|
||
Thanks again :)
Landed in master:
https://github.com/mozilla-b2g/gaia/commit/ecb917519cc18df6db706dcb72881741cdb69bf4
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(pivanov)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•