939283 - [B2G][Contacts]When exporting contacts, check mark boxes are truncated.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Peter Bylenga [:PBylenga]]

Attachment: ExportContacts_SelectionBoxesTruncated.png

Description:
After selecting to export contacts, the check mark boxes next to the contacts are truncated.

Prerequisites:
Have contacts available to export.

Repro Steps:
1) Updated Buri to Build ID: 20131115004003
2) Launch Contacts App
3) Navigate to Contacts Settings
4) Select Export Contacts and a device to export to
5) Observe Selection Check Mark Boxes

Actual:
Box UI are truncated.

Expected:
All box UI are viewable in its entirety.

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131115004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/ff2c7c9d01d6
Gaia: a6484b1e6fc07cf6bd8d6fcf9aeebb14b7e8869d
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: US_20131104

Notes:
Repro frequency: 5/5, 100%
See attached: screenshot

Comment 1

[Jason Smith [:jsmith]]

We need a regression range. Whatever VD patch that landed here needs to be backed out.

Comment 2

[Peter Bylenga [:PBylenga]]

I was able to find the regression range for this issue.

Last Build that does not reproduce issue

Environmental Variables:
Device: Buri v1.2 Mozilla RIL
BuildID: 20131113004000
Gaia: 20e8d407dac3bb2ad2616e8c2d8678d70fd82fa0
Gecko: 3fc449c858e6
Platform Version: 26.0
Firmware Version: v1.2_20131115

First Build that reproduces issue

Environmental Variables:
Device: Buri v1.2 COM RIL
Build ID: 20131114004004
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/948e30162eac
Gaia: 3e67ddf7d2680d1ef01441641f4ca2e0e4006887
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: v1.2_20131115

Comment 3

[Jason Smith [:jsmith]]

The suspicious candidate for causing this is bug 937291.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

It seems my overflow:hidden changes caused this.  Let me investigate to see if I can find a solution.  I'd like to keep the overflow improvement if I can.

Comment 5

[Jason Smith [:jsmith]]

This is definitely one ugly VD fallout, but someone from UX is going to need to push back here if we need this on 1.2.

Can I get a UX opinion on whether this is a blocker for VD for 1.2?

Comment 6

[Stephany Wilkes]

This is a blocker. Tapping is hard enough as it is without the user feeling they have to attempt to hit an even smaller target. Thanks, Jason!

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Reverted bug 937291.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Ben Kelly [:bkelly] from comment #7)
> Reverted bug 937291.

do you have the hash for this?  Please post it here.  Did you also back out on v1.2?  It looks like it was landed on that branch as well.

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #8)
> (In reply to Ben Kelly [:bkelly] from comment #7)
> > Reverted bug 937291.
> 
> do you have the hash for this?  Please post it here.  Did you also back out
> on v1.2?  It looks like it was landed on that branch as well.

Yes, I reverted on 1.2 as well.  The revs are in bug 937291 comment 5.  I then re-landed and re-uplifted a fixed patch.