Closed Bug 939355 Opened 6 years ago Closed 6 years ago

TestBugs.cpp needs to include string.h (memcmp undefined w/clang opt builds)

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: johns, Assigned: johns)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Include string.h in gfx/2d/unittest/TestBugs.cpp
807 bytes, patch
BenWa
: review+
Details | Diff | Splinter Review 
The unit test added in Bug 918671 uses memcmp, but when using clang on linux with --enable-optimize string.h doesn't end up in the include tree
Comment on attachment 833252 [details] [diff] [review]
Include string.h in gfx/2d/unittest/TestBugs.cpp

Review of attachment 833252 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you
Attachment #833252 - Flags: review?(bgirard) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1ac2fad87f3c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.