Closed
Bug 939355
Opened 12 years ago
Closed 12 years ago
TestBugs.cpp needs to include string.h (memcmp undefined w/clang opt builds)
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: johns, Assigned: johns)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
807 bytes,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
The unit test added in Bug 918671 uses memcmp, but when using clang on linux with --enable-optimize string.h doesn't end up in the include tree
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #833252 -
Flags: review?(bgirard)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 833252 [details] [diff] [review]
Include string.h in gfx/2d/unittest/TestBugs.cpp
Review of attachment 833252 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you
Attachment #833252 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ac2fad87f3c
(i also hit it on sparc64/gcc)
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•