TestBugs.cpp needs to include string.h (memcmp undefined w/clang opt builds)

RESOLVED FIXED in mozilla28

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: johns, Assigned: johns)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The unit test added in Bug 918671 uses memcmp, but when using clang on linux with --enable-optimize string.h doesn't end up in the include tree
(Assignee)

Comment 1

5 years ago
Created attachment 833252 [details] [diff] [review]
Include string.h in gfx/2d/unittest/TestBugs.cpp
Attachment #833252 - Flags: review?(bgirard)
Comment on attachment 833252 [details] [diff] [review]
Include string.h in gfx/2d/unittest/TestBugs.cpp

Review of attachment 833252 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you
Attachment #833252 - Flags: review?(bgirard) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Keywords: checkin-needed

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1ac2fad87f3c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Keywords: checkin-needed

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.