939377 - [Bluetooth] 1.3 Visual Refresh of Bluetooth Icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: Bluetooth_sprite.zip

Hi Pavel,

Please update the Bluetooth sprites with the @1 and @1.5 sprites attached. 

Thanks!

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 2

[Eric Pang [:epang] UX]

Comment on attachment 833454 [details] [review]
patch for Gaia/master

Hey Amy, i'm changing the feedback request to you since worked on the icons.  Pavel do you know if there's a good way for Amy to test these?  Is there a way to make the icons show up?

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

not really ... but if Amy have a chance to flash a device we can talk on irc (I have an idea)
Amy can you flash your device?

Comment 4

[Amy Lee [:amylee] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #3)
> not really ... but if Amy have a chance to flash a device we can talk on irc
> (I have an idea)
> Amy can you flash your device?

Hey Pavel, 

I was just given a device with 1.3 today so I should be able to flash it. What's your username on IRC? Or you can ping me AmyLee

Comment 5

[Eric Pang [:epang] UX]

Hey Pavel, I was able to find a way to review this :).  A few issues I found...

1. The icons need to be shifted to the right (with a 15px margin, I think they are currently using 30px)
2. 3 types of devices don't show their icons from the sprite.
     a. printer
     b. scanner
     c. video-display

Can you fix these issues and let me know when it's ready for me to review? Thanks!

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Eric,
can you test the PR now :) I think it's ok

Comment 7

[Eric Pang [:epang] UX]

Attachment: 2013-11-25-14-55-46.png

the icons are all showing up now :), thanks!  A couple more small changes. 
1. Can you add a margin on the right of where the devices are displayed?  Currenrly the text is overlapping the icon.  
2. Shift "Searching for devices..." to the right so it has a 3rem left margin (and is aligned with the rest of the text)

Thanks!

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

You can test the PR too :)

Comment 9

[Eric Pang [:epang] UX]

Comment on attachment 833454 [details] [review]
patch for Gaia/master

Looks good now, thanks Pavel! Ready for Review.

Comment 10

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 833454 [details] [review]
patch for Gaia/master

Sorry for the late reply and I'm not the right person to review this patch. Let's re-direct the review request to Arthur.

Comment 11

[Evelyn Hung]

Comment on attachment 833454 [details] [review]
patch for Gaia/master

looks good to me. Thanks.

Comment 12

[Evelyn Hung]

merged into master: https://github.com/mozilla-b2g/gaia/commit/4c52edca65d6ea1fbb89148a01e47fc94eaa0bbc

Comment 13

[[e-mail], [e-mail]]

Looks like the merged patch was missed to update in Bluetooth app. So that there is an existed Bug 979981 - [B2G] [Bluetooth] Truncated devices names will have their ellipses overlap the icon. I will give a patch there.