939383 - Quicklinks / Subnav overflowing into footer

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Design, defect, P1)

Description

[John Karahalis [:openjck]]

Steps to reproduce:

1. Create a new page with this source, or any other source with short
   content, a long Subnav, and a long quicklinks section:
   http://pastebin.mozilla.org/3613473

Actual:

http://i.imgur.com/cSPjkhH.png

Expected:

The page should be at least as long as the sidebar.

Comment 1

[John Karahalis [:openjck]]

Interested in what is causing this. I tried adding "@extend .clear" to some of the classes in the sidebar without success.

Comment 2

[David Walsh :davidwalsh]

This is a dupe.  The problem is that the element is position:absolute so it doesn't clear in any way.

Comment 3

[ali spivak]

This is a blocker (not sure what the dupe bug # is)

Comment 4

[David Walsh :davidwalsh]

This was the dupe, deemed not a blocker:  https://bugzilla.mozilla.org/show_bug.cgi?id=932540

Where does this happen in production now?

Comment 5

[John Karahalis [:openjck]]

It may not be happening anywhere on production currently, but it can be reproduced in Vagrant by creating a page with short content and a long sidebar.

Sheppy, do you know of any places on production where this is happening currently?

Comment 6

[David Walsh :davidwalsh]

Yes, but if it's an edge edge bug, it shouldn't be a launch blocker.  Also, it will take a lot of time to find a solution for, since the element is absolutely positioned and I cannot count on any height anywhere on the page.

Comment 7

[ali spivak]

ok, let's take it off the blocker list, I'll make it a high priority post-launch bug

Comment 8

[Eric Shepherd [:sheppy]]

(In reply to John Karahalis [:openjck] from comment #5)
> It may not be happening anywhere on production currently, but it can be
> reproduced in Vagrant by creating a page with short content and a long
> sidebar.
> 
> Sheppy, do you know of any places on production where this is happening
> currently?

Yes -- go to https://developer.mozilla.org/en-US/docs/Project:MDN and click "Contributing to MDN" in the sidebar. When that expands, the footer is overdrawn.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/ee35644c60e81662354f789f6797d516e947f8a2
fix bug 939383 - modify content min-height for zone nav

https://github.com/mozilla/kuma/commit/24273672a6559edf990957c2cb40b894622ea8a3
Merge pull request #1959 from darkwing/subnav-height-939383

fix bug 939383 - modify content min-height for zone nav