Closed Bug 939394 Opened 11 years ago Closed 11 years ago

Tag static rooting hazard analysis results with TinderboxPrint

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

The main output of these jobs is the number of hazards and unsafe references, and the URL of the uploaded analysis. Display these in tbpl.
It looks like this is the way to do it.
Attachment #833317 - Flags: review?(aki)
Summary: Tag results with TinderboxPrint → Tag static rooting hazard analysis results with TinderboxPrint
Comment on attachment 833317 [details] [diff] [review]
Tag results with TinderboxPrint:

The comma may look weird here:
+        self.info("TinderboxPrint: " + ", ".join(status))
but I don't have a strong opinion about it.
Attachment #833317 - Flags: review?(aki) → review+
something[s] here made it to production
Yeah, this is working, but it's not very pretty. Something inserts a space between http: and the rest. And I discovered that I can TinderboxPrint HTML, so I can make this a direct link. I'll do that in another bug.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Ah, welcome to the trail of tears. Just don't let your TinderboxPrint .match(/rev(ision)?\:/), or tbpl will throw it on the floor in https://hg.mozilla.org/webtools/tbpl/file/ac35be9cb467/js/MachineResult.js#l55.

The stupid http: // comes from the next-door-neighbor to that, in https://hg.mozilla.org/webtools/tbpl/file/ac35be9cb467/js/MachineResult.js#l57, because tbpl is pure reverse-engineering, and at the time every TinderboxPrint was "thing: whatever" or "thing: <a href..." but never "thing is <a href..." without a colon after a text label. "self.info("TinderboxPrint: uploaded: %s" % upload_url))" would have worked fine, as would have "self.info("TinderboxPrint: here's an extraneous colon: :, uploaded to %s" % upload_url)". Even in your HTML version, you still want a colon before the link, because tbpl don't care, it'll do <a href="http: //...">uploaded</a> to you and laugh.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: