Implement memory stat dumping for browser-chrome

RESOLVED FIXED in mozilla28

Status

RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: shu, Assigned: shu)

Tracking

(Blocks: 1 bug)

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Following in the format of bug 939137, we should also dump memory stat for BC.

Since 99% of the time we care about the main process, only dump for the main process in BC for now.

Should also print resident in addition to vsize and maximum contiguous VM block.
(Assignee)

Updated

5 years ago
Assignee: nobody → shu
Whiteboard: [MemShrink]
(Assignee)

Comment 1

5 years ago
Created attachment 833415 [details] [diff] [review]
wip

Cargo culting all the stuff about the plain mochitest harness. No idea what the
steps are to ensuring that the new MemoryStats.js file gets loaded in the right
places, so please check that for me.
Attachment #833415 - Flags: review?(nfroyd)
(Assignee)

Comment 2

5 years ago
Comment on attachment 833415 [details] [diff] [review]
wip

Flipping review to ted for the harness stuff.
Attachment #833415 - Flags: review?(nfroyd) → review?(ted)
(Assignee)

Comment 4

5 years ago
Viewer is here: http://people.mozilla.org/~sguo/mochimem/

Updated

5 years ago
Blocks: 938691
(In reply to Shu-yu Guo [:shu] from comment #4)
> Viewer is here: http://people.mozilla.org/~sguo/mochimem/

Woah, that's awesome.  There are a few places in bc where contiguous memory drops, though nothing as dramatic as M2.
Comment on attachment 833415 [details] [diff] [review]
wip

Review of attachment 833415 [details] [diff] [review]:
-----------------------------------------------------------------

I like putting everything into MemoryStats.js; I'll have to use that for my upcoming DMD/about:memory stuff.

::: testing/mochitest/tests/SimpleTest/MemoryStats.js
@@ +13,5 @@
> +var MEM_STAT_SUPPORTED = 2;
> +
> +MemoryStats._hasMemoryStatistics = {}
> +MemoryStats._hasMemoryStatistics.vsize = MEM_STAT_UNKNOWN;
> +MemoryStats._hasMemoryStatistics.resident = MEM_STAT_UNKNOWN;

Please use residentFast; .resident has poor behavior on OS X.
Attachment #833415 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/e889f242bb58
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Component: Mochitest Chrome → Mochitest
Product: Testing → Testing
You need to log in before you can comment on or make changes to this bug.