939434 - Lock screen handle does not return to it's original position when you hit "cancel" from passcode panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. set a passcode in the setting app
2. turn off the screen, and turn it back on
3. hit cancel
4. drag the handle to the unlock position to return to passcode screen
5. hit cancel

Expected:

1. a lock screen main panel with handle in it's original position

Actual:

1. handle remain in it's blue-ish engaged position.

Greg, could you fix this? Should be quick. Thanks.

Triage: should be blocked unless it does not reproduce in v1.2

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

I'll try it ASAP.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Well, this may be a good first bug because of it's simplicity. However it's koi+, so here is the patch.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8333631 [details] [review]
Patch

Thanks!

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/28e7dd59cf5b8ad9b197c59fbf92603e934e0474

Comment 5

[Carsten Book [:Tomcat]]

Hi Tim,

had to revert/backout this change in https://github.com/mozilla-b2g/gaia/commit/9f72bf98cb7c256d80c8cb2e5cbbeaa39fd15765 because of bustage/faiure in gaia unit tests like https://tbpl.mozilla.org/php/getParsedLog.php?id=30700831&tree=B2g-Inbound

Comment 6

[Julien Wajsberg [:julienw]]

So this was not reverted (see bug 937630 comment 50)

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 28e7dd59cf5b8ad9b197c59fbf92603e934e0474 to:
v1.2: 927c819e44865171bf927aa40eb801d72ec81500