939475 - gcparam() help and error message do not mention markStackLimit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Error message:
http://mxr.mozilla.org/mozilla-central/source/js/src/builtin/TestingFunctions.cpp#287

Help:
http://mxr.mozilla.org/mozilla-central/source/js/src/builtin/TestingFunctions.cpp#1344

Comment 1

[Michael]

Attachment: Patch

I assume sliceTimeBudget also needs to be included.

Comment 2

[Luke Wagner [:luke]]

The parameters listed still don't seem to match the list:
  http://mxr.mozilla.org/mozilla-central/source/js/src/builtin/TestingFunctions.cpp#259
Instead of duplicating this list in several places (which are sure to go stale before long), can you have a

#define GC_PARAMETER_ARGS_LIST "maxBytes, maxMallocBytes, ..."

right above/below the paramMap and used twice below?

Comment 3

[Michael]

Attachment: Patch (v2)

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 8334237 [details] [diff] [review]
Patch (v2)

Review of attachment 8334237 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: js/src/builtin/TestingFunctions.cpp
@@ +268,5 @@
>      {"markStackLimit",      JSGC_MARK_STACK_LIMIT}
>  };
>  
> +// Keep this in sync with above params.
> +#define GC_PARAMETER_ARGS_LIST "maxBytes, maxMallocBytes, gcBytes, gcNumber, sliceTimeBudget, markStackLimit"

Could you add a \n after this line?  Also, could you insert " or " before markStackLimit?

Comment 5

[Michael]

Attachment: Patch with review comments addressed. r=luke

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca39b88accf3

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca39b88accf3