Closed
Bug 939513
Opened 12 years ago
Closed 12 years ago
Symbolize ASan traces seems broken for xpcshell tests
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: decoder, Assigned: decoder)
References
(Blocks 1 open bug)
Details
(Keywords: sec-want)
Attachments
(1 file)
|
2.77 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
One of the TBPL logs philor gave me suggests that ASan trace symbolizing doesn't work for xpcshell tests. Initial investigation seems to show that xpcshell tests use their own function for building environment variables when running tests:
http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#839
This function needs to be patched the same way we did it for mochitests and compiled tests in bug 917242.
|
Assignee | |
Comment 1•12 years ago
|
||
This patch works on try with a simulated xpcshell crash :)
Attachment #8335268 -
Flags: review?(ted)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8335268 [details] [diff] [review]
asan-xpcshell-symbols.patch
Review of attachment 8335268 [details] [diff] [review]:
-----------------------------------------------------------------
Feels like maybe we should move that llvm-symbolizer logic into automationutils.py.
Attachment #8335268 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
As discussed on IRC, the whole "core environment" logic should probably be moved to automationutils.py instead of every framework using their own.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3893c3542f07
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•