Closed Bug 939513 Opened 6 years ago Closed 6 years ago

Symbolize ASan traces seems broken for xpcshell tests

Categories

(Firefox Build System :: General, defect, major)

x86_64
Linux
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want)

Attachments

(1 file)

One of the TBPL logs philor gave me suggests that ASan trace symbolizing doesn't work for xpcshell tests. Initial investigation seems to show that xpcshell tests use their own function for building environment variables when running tests:

http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#839

This function needs to be patched the same way we did it for mochitests and compiled tests in bug 917242.
This patch works on try with a simulated xpcshell crash :)
Attachment #8335268 - Flags: review?(ted)
Comment on attachment 8335268 [details] [diff] [review]
asan-xpcshell-symbols.patch

Review of attachment 8335268 [details] [diff] [review]:
-----------------------------------------------------------------

Feels like maybe we should move that llvm-symbolizer logic into automationutils.py.
Attachment #8335268 - Flags: review?(ted) → review+
As discussed on IRC, the whole "core environment" logic should probably be moved to automationutils.py instead of every framework using their own.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3893c3542f07
https://hg.mozilla.org/mozilla-central/rev/3893c3542f07
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.