939615 - Do not allow files which have custom build flags to be added to UNIFIED_SOURCES

Status: UNCONFIRMED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

AudioNodeEngineNEON.cpp is one such file.  The problem is that those flags are declared in the Makefile.in's, and if we're not lucky we might never realize that we're building those files with the wrong options.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

I hit that with the SSE files under gfx/skia/ too. The idea proposed here would have saved me some time.

Comment 3

[Mike Hommey [:glandium]]

Gah, wrong bug

Comment 4

[Mike Hommey [:glandium]]

Let's be realistic. This is not possible without moving this CXXFLAGS knowledge to moz.build, and I doubt we'll be there before most of the tree is built in unified mode.

Comment 5

[(no longer active)]

Is there any workarounds that we could take in the mean time?

Comment 6

[Mike Hommey [:glandium]]

find -name Makefile.in | xargs grep OBJ_SUFFIX

Comment 7

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #4)
> Let's be realistic. This is not possible without moving this CXXFLAGS
> knowledge to moz.build

(and the dependency knowledge, like that issue in xpconnect)