[Bluedroid] defaultAdapter.address has no value

RESOLVED FIXED in 1.3 Sprint 5 - 11/22

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: echou, Assigned: echou)

Tracking

unspecified
1.3 Sprint 5 - 11/22
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
In BluetoothServiceBluedroid::GetDefaultAdapterPathInternal(), when a request for creating BluetoothAdapter object have been received, we should append full properties to the BluetoothValue variable, otherwise some properties would not be available.
(Assignee)

Updated

5 years ago
Assignee: nobody → echou
(Assignee)

Comment 1

5 years ago
Created attachment 8333687 [details] [diff] [review]
patch 1: v1: append missed properties to BluetoothAdapter

* Added property "address", "discoverable" and "discoverable timeout" to the property array which would be fired back to BluetoothAdapter along with the runnable.
Attachment #8333687 - Flags: review?(gyeh)
(Assignee)

Updated

5 years ago
Depends on: 936732
Comment on attachment 8333687 [details] [diff] [review]
patch 1: v1: append missed properties to BluetoothAdapter

Review of attachment 8333687 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me.
Attachment #8333687 - Flags: review?(gyeh) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 8334304 [details] [diff] [review]
patch 1: final: append missed properties to BluetoothAdapter, r=gyeh

* Final patch with cleanup.
Attachment #8333687 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/8df004b1a1ec
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 5 - 11/22
You need to log in before you can comment on or make changes to this bug.