939821 - wrapper scripts for vcs-sync, gaia-bumper need timeouts for hg

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

The vcssync{1,2} wrapper scripts have a

    (hg --cwd mozharness pull -u)

The gaia-bumper wrapper script has a

    /usr/local/bin/hgtool.py -b production https://hg.mozilla.org/build/mozharness mozharness

Neither of these has a timeout... and when hg.m.o goes away, the clone will hang forever.

There's a bash timeout trick here:
http://stackoverflow.com/questions/687948/timeout-a-command-in-bash-without-unnecessary-delay

but it exits non-zero either way (timeout will cause hg to exit non-zero; no-timeout will cause kill to exit non-zero) so the script will fail at this point if it's using set -e.  We need a better solution.

Comment 1

[Aki Sasaki (not active)]

Ooh, http://stackoverflow.com/a/4581821

timeout TIMEOUT <slow command>

Comment 2

[Aki Sasaki (not active)]

Attachment: gaia-bumper-timeout

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 8333883 [details] [diff] [review]
gaia-bumper-timeout

Review of attachment 8333883 [details] [diff] [review]:
-----------------------------------------------------------------

TIL about the timeout command!

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 8333883 [details] [diff] [review]
gaia-bumper-timeout

https://hg.mozilla.org/build/puppet/rev/043150c92101

Comment 5

[Aki Sasaki (not active)]

Not merged yet, but I'll resolve anyway.
I already tweaked the non-puppeted scripts for vcssync.

Comment 6

[Rail Aliiev [:rail]]

in production