939844 - seconds are no longer shown on a comment's time

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[:glob ✱]

seconds are no longer shown on a comment's time.

this is because the time FILTER is incorrectly defined, and the value of $format is inherited from the previous call if not defined.

when displaying a comment's time the format isn't provided, so it's using the format from the attachment table, which skips comments.

Comment 1

[:glob ✱]

Attachment: 939844_1.patch

Comment 2

[Frédéric Buclin]

There are much more regressions than this, as expected. The creation and modifications times in bug reports now display seconds when they didn't before, same for attachment creation times, same when editing attachments.

Comment 3

[:glob ✱]

Comment on attachment 8333917 [details] [diff] [review]
939844_1.patch

indeed; something weird is going on here, will figure it out.
using a format in one place in the template shouldn't impact other locations.

Comment 4

[:glob ✱]

Attachment: 939844_2.patch

how template-toolkit's filter cache works is if an alias is provided then the sub returned by the filter factory will be cached.  this cache is used when the filter is subsequently called without any arguments.  the current behaviour is to unconditionally cache a sub.

the problem this causes is when a filter has default values for parameters, such as the time filter.

when the filter is called from the attachments table, the format without the seconds displayed is cached.  when the comment time is formatted, it's called without parameters which results in it re-using the cached sub including its format.

the fix is to not cache filters if arguments are passed to them.  the normal case of | something FILTER time | is cached correctly even with this change.

Comment 5

[:glob ✱]

Attachment: 939844_3.patch

of course after attaching i realised i (1) left in some debugging code, and (2) don't need to touch the filter at all.

Comment 6

[Frédéric Buclin]

Comment on attachment 8334380 [details] [diff] [review]
939844_3.patch

Nice catch! r=LpSolit

Comment 7

[Frédéric Buclin]

The filter cache was implemented in Bugzilla 5.0, see bug 797636, so this cache issue affects trunk only.

Comment 8

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Template/Context.pm
Committed revision 8815.