9400 - Mozilla configure on Solaris just broke! X related error.

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Mo DeJong]

I just pulled a fresh CVS tree (Jul 7 99), and tried to build on a Solaris
box. This worked a couple of days ago but now it does not configure anymore.

% ../configure

creating cache ./config.cache
checking host system type... sparc-sun-solaris2.6
checking target system type... sparc-sun-solaris2.6
checking build system type... sparc-sun-solaris2.6
checking for gcc... gcc
checking whether the C compiler (gcc  ) works... yes
checking whether the C compiler (gcc  ) is a cross-compiler... no
checking whether we are using GNU C... yes
checking whether gcc accepts -g... yes
checking for c++... c++
checking whether the C++ compiler (c++  ) works... yes
checking whether the C++ compiler (c++  ) is a cross-compiler... no
checking whether we are using GNU C++... yes
checking whether c++ accepts -g... yes
checking whether gcc and cc understand -c and -o together... yes
checking how to run the C preprocessor... gcc -E
checking how to run the C++ preprocessor... c++ -E
checking for a BSD compatible install... /opt/gnu/bin/install -c
checking for mawk... no
checking for gawk... gawk
checking for ranlib... ranlib
checking for gmake... no
checking for make... /opt/gnu/bin/make
checking whether /opt/gnu/bin/make sets ${MAKE}... yes
checking for makedepend... /soft/X11R6.3/bin/makedepend
checking for xemacs... /soft/xemacs-20.4/sunos-56/bin/xemacs
checking for perl5... /opt/gnu/bin/perl5
checking for whoami... /usr/ucb/whoami
checking for unzip... /opt/local/bin/unzip
checking for zip... /opt/local/bin/zip
checking for X... libraries /soft/X11R6.3/lib, headers /soft/X11R6.3/include
checking whether -R must be followed by a space... no
checking for dnet_ntoa in -ldnet... no
checking for dnet_ntoa in -ldnet_stub... no
checking for gethostbyname... no
checking for gethostbyname in -lnsl... yes
checking for connect... no
checking for connect in -lsocket... yes
checking for remove... yes
checking for shmat... yes
checking for IceConnectionNumber in -lICE... yes
checking whether ld has archive extraction flags... yes
checking for XDrawLines in -lX11... yes
checking for XextAddDisplay in -lXext... no
checking for IceFlush in -lICE... yes
checking for SmcCloseConnection in -lSM... no
checking for XtFree in -lXt... no
checking for XmuLookupString in -lXmu... yes
checking for gtk-config...
/home/grad03/dejong/neon/mozilla/install_solaris/bin/gtk-config
checking for GTK - version >= 1.2.0... yes
checking for glib-config...
/home/grad03/dejong/neon/mozilla/install_solaris/bin/glib-config
checking for GLIB - version >= 1.2.0... yes
checking for libIDL-config...
/home/grad03/dejong/neon/mozilla/install_solaris/bin/libIDL-config
checking for libIDL - version >= 0.6.3... yes
checking for working const... yes
checking for ANSI C header files... yes
checking for mode_t... yes
checking for off_t... yes
checking for pid_t... yes
checking for size_t... yes
checking for uid_t in sys/types.h... yes
checking for st_blksize in struct stat... yes
checking for st_rdev in struct stat... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking for tm_zone in struct tm... no
checking for tzname... yes
checking for int16_t... yes
checking for int32_t... yes
checking for int64_t... yes
checking for int64... no
checking for uint... yes
checking for uint_t... yes
checking for uint16_t... yes
checking for dirent.h that defines DIR... yes
checking for opendir in -ldir... no
checking for sys/wait.h that is POSIX.1 compatible... yes
checking whether time.h and sys/time.h may both be included... yes
checking for fcntl.h... yes
checking for limits.h... yes
checking for malloc.h... yes
checking for memory.h... yes
checking for paths.h... no
checking for strings.h... yes
checking for sys/bittypes.h... no
checking for sys/byteorder.h... yes
checking for sys/file.h... yes
checking for sys/ioctl.h... yes
checking for sys/time.h... yes
checking for getopt.h... no
checking for ioctl.h... no
checking for filio.h... no
checking for systeminfo.h... no
checking for compat.h... no
checking for sys/statvfs.h... yes
checking for sys/statfs.h... yes
checking for sys/vfs.h... yes
checking for sys/mount.h... yes
checking for sys/cdefs.h... no
checking for gethostbyname_r in -lc_r... no
checking for atan in -lm... yes
checking for dlopen in -ldl... yes
checking for res_gethostbyaddr in -lresolv... yes
checking for getnetbyaddr in -lsocket... yes
checking for login in -lutil... no
checking for xdr_string in -lnsl... yes
checking for elf_rawdata in -lelf... yes
checking for textdomain in -lintl... yes
checking for shm_open in -lposix4... yes
checking for iswupper in -lw... yes
checking for pthread_attr_init in -lpthread... yes
checking whether gcc accepts -pthread... no
checking for PR_GetCurrentThread in -lnspr3... no
checking for PR_GetCurrentThread in -lnspr3 with thread lib... no
checking for PL_CreateOptState in -lplc3... yes
checking for PL_GetEvent in -lplds3... yes

*** NSPR was not detected in your system.  This is not a problem.
*** I will use the one in the current source tree instead.

checking for working alloca.h... yes
checking for alloca... yes
checking whether gcc needs -traditional... no
checking for 8-bit clean memcmp... yes
checking for unistd.h... yes
checking for getpagesize... yes
checking for working mmap... yes
checking return type of signal handlers... void
checking for working strcoll... yes
checking for strftime... yes
checking whether utime accepts a null argument... yes
checking for vfork.h... no
checking for working vfork... yes
checking for vprintf... yes
checking for fchmod... yes
checking for fork1... yes
checking for ftime... yes
checking for getcwd... yes
checking for getwd... yes
checking for gethostname... yes
checking for lchown... yes
checking for localtime_r... yes
checking for mkdir... yes
checking for mktime... yes
checking for putenv... yes
checking for qsort... yes
checking for random... yes
checking for remainder... yes
checking for rmdir... yes
checking for select... yes
checking for setvbuf... yes
checking for snprintf... yes
checking for socket... yes
checking for statvfs... yes
checking for strcspn... yes
checking for strdup... yes
checking for strerror... yes
checking for strspn... yes
checking for strstr... yes
checking for strtol... yes
checking for strtoul... yes
checking for uname... yes
checking for waitid... yes
checking how to call gettimeofday... two arguments
checking for sys_errlist/sys_nerr... no
checking for C++ exceptions flag... -fno-exceptions
checking for ios::binary... yes
checking for ios::bin... yes
checking for namespaces... yes
checking for ostreams... yes
checking for C++ "bool" keyword... yes
checking for C++ "explicit" keyword... yes
checking for C++ template specialization support... yes
checking for C++ "using" keyword... yes
checking for C++ reinterpret_cast... yes
checking whether C++ requires implementation of unused methods... no
checking for LC_MESSAGES... yes
checking for jpeg_destroy_compress in -ljpeg... no
checking for zlib.h... yes
checking for gzread in -lz... no
checking for png_get_valid in -lpng... no
configure: error:  Could not find the following X libraries:  -lXext -lXt


Any ideas?

Comment 1

[Mo DeJong]

Attachment: config.log

Comment 2

[Brian Ostrom]

I was told that Ramiro knew about this and either already fixed it
or was working on a fix.  Ramiro?

Comment 3

[Brian Ostrom]

The problem seems to be that -lX11 is not part of the link command.
It looks like $XLIBS isn't set to anything when the X tests are run.
That is, if you look at configure, you see LIBS=-lXext $XLIBS $LIBS,
but all you see in the config.log is -lXext  -lsocket -lnsl, so I
think if XLIBS would just default to -lX11 just for the X lib tests,
then Solaris builds will work again.

BTW: Both of my nightly Solaris 2.5.1 builds (sparc and x86) failed
today because of this problem, so it definitely needs to be fixed.

Comment 4

[ramiro]

I just tried it on a solaris 2.6 box and it worked for me.

The way that XLIBS were being set was wrong and I fixed it.  I did make sure it
works on solaris.

I dont have time to look at this anymore right now.

Im taking it off the radar and reassigning to briano.

If you change configure, make sure that TK_LIBS does not change how it currently
works - at least on linux.  Before, there were multiple libs in there, and even
ones that are not needed - like -lXt.

Comment 5

[Brian Ostrom]

As I expected, this problem turned out to be trivial.  I'm about to
check in (when I get approval) the following one-line change to
configure.in (and configure).  Please let me know if this is a problem.

Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.379
diff -c -r1.379 configure.in
*** configure.in        1999/07/08 23:12:57     1.379
--- configure.in        1999/07/08 23:27:25
***************
*** 155,161 ****
  AC_PATH_XTRA

  XLDFLAGS="$X_LIBS"
! XLIBS="$X_EXTRA_LIBS"

  GNU_CC=
  GNU_CXX=
--- 155,161 ----
  AC_PATH_XTRA

  XLDFLAGS="$X_LIBS"
! XLIBS="-lX11 $X_EXTRA_LIBS"

  GNU_CC=
  GNU_CXX=


I moved it back to M8 because without this fix, I can't build and
deliver the nightly Solaris builds to ftp://ftp.mozilla.org/.

Comment 6

[Brian Ostrom]

Added ramiro to the cc: list for his input.

Comment 7

[Brian Ostrom]

Fix checked in.

Comment 8

[Mo DeJong]

First off, I was not able to update from the CVS because it seems like the CVS
is down today. Is that a known problem? I then applied your patch to my
configure.in file to see if that would work. It did not. When I ran configure
again I got this error.

../configure
...
checking for LC_MESSAGES... yes
checking for jpeg_destroy_compress in -ljpeg... no
checking for zlib.h... yes
checking for gzread in -lz... no
checking for png_get_valid in -lpng... no
configure: error:  Could not find the following X libraries:  -lXt


So to sum things up, I do not think this has been fixed. Has anyone
else been able to build on Solaris with this patch applied?

Comment 9

[Mo DeJong]

With the most recent CVS this has been fixed.