Closed Bug 940014 Opened 6 years ago Closed 6 years ago

Record telemetry for recursive scan of individual add-ons at startup

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: Irving, Assigned: Irving)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

For bug 810149 I'd like to find out if particular add-ons are causing the slow start up. This patch records the time taken for the directory scan of each add-on.
Attachment #8334091 - Flags: review?(bmcbride)
We'll have to adjust the timings for different hardware speeds.. it might be preferrable to also keep track of the # of file ops.. i.e. files stated and directories recursed in the extension directory
(In reply to Vladan Djeric (:vladan) from comment #1)
> it might be
> preferrable to also keep track of the # of file ops.. i.e. files stated and
> directories recursed in the extension directory

Is it worth doing that here? We'll end up looking at the XPIs of any outliers anyway.
Comment on attachment 8334091 [details] [diff] [review]
Record duration of add-on modified check for each add-on

Review of attachment 8334091 [details] [diff] [review]:
-----------------------------------------------------------------

On the assumption that this data is enough, but we can always add even more data in a followup anyway.
Attachment #8334091 - Flags: review?(bmcbride) → review+
OK, here's a version that also tracks the number of items we stat. Once we see which measurement is more useful we can remove the other.
Attachment #8334091 - Attachment is obsolete: true
Attachment #8334326 - Flags: review?(bmcbride)
Attachment #8334326 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/01a236fd6933
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Blocks: 810149
You need to log in before you can comment on or make changes to this bug.