940014 - Record telemetry for recursive scan of individual add-ons at startup

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[:Irving Reid (No longer working on Firefox)]

Attachment: Record duration of add-on modified check for each add-on

For bug 810149 I'd like to find out if particular add-ons are causing the slow start up. This patch records the time taken for the directory scan of each add-on.

Comment 1

[Vladan Djeric (:vladan)]

We'll have to adjust the timings for different hardware speeds.. it might be preferrable to also keep track of the # of file ops.. i.e. files stated and directories recursed in the extension directory

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Vladan Djeric (:vladan) from comment #1)
> it might be
> preferrable to also keep track of the # of file ops.. i.e. files stated and
> directories recursed in the extension directory

Is it worth doing that here? We'll end up looking at the XPIs of any outliers anyway.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8334091 [details] [diff] [review]
Record duration of add-on modified check for each add-on

Review of attachment 8334091 [details] [diff] [review]:
-----------------------------------------------------------------

On the assumption that this data is enough, but we can always add even more data in a followup anyway.

Comment 4

[:Irving Reid (No longer working on Firefox)]

Attachment: Record duration of add-on modified check and number of items scanned for each add-on

OK, here's a version that also tracks the number of items we stat. Once we see which measurement is more useful we can remove the other.

Comment 5

[:Irving Reid (No longer working on Firefox)]

https://hg.mozilla.org/integration/fx-team/rev/01a236fd6933

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01a236fd6933