Add Reload And Run to the context menu

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Developer Tools: Scratchpad
P3
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: past, Assigned: Dan Koepke)

Tracking

unspecified
Firefox 28
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js])

Attachments

(1 attachment, 2 obsolete attachments)

We apparently forgot to add Reload And Run to the context menu, even though it is present in the regular Execute menu.
Priority: -- → P3
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js]
(Assignee)

Comment 1

4 years ago
Created attachment 8335117 [details] [diff] [review]
bug940016.diff

This is my first submission. I think I have a properly formatted patch, and I know I need to ask for the patch to be reviewed, but I'm not sure how. Via flags? With this comment?
Flags: needinfo?
Thanks Dan!

When you add an attachment there is an option to ask for a review: http://cl.ly/image/320Y3N2P3508. Alternatively, you can also click on the [details] link next to your attachment and ask for a review from there.

The patch looks good to me but I'll let Brandon to do the final call since he's a mentor here.
Flags: needinfo?
Assignee: nobody → koepked
(Assignee)

Updated

4 years ago
Attachment #8335117 - Flags: review?(bbenvie)
(Assignee)

Comment 3

4 years ago
(In reply to Anton Kovalyov (:anton, @valueof) from comment #2)
> Thanks Dan!
> 
> When you add an attachment there is an option to ask for a review:
> http://cl.ly/image/320Y3N2P3508. Alternatively, you can also click on the
> [details] link next to your attachment and ask for a review from there.

Sounds good. Thanks Anton!
Comment on attachment 8335117 [details] [diff] [review]
bug940016.diff

Review of attachment 8335117 [details] [diff] [review]:
-----------------------------------------------------------------

The change looks good, however we should also make sure this is tested. There's a test [1] that already runs through the menus, so you just have to add the menu to the list to test. r+ with it added to the test.

[1] http://mxr.mozilla.org/mozilla-central/source/browser/devtools/scratchpad/test/browser_scratchpad_ui.js#31
Attachment #8335117 - Flags: review?(bbenvie) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 8335672 [details] [diff] [review]
bug940016+test.diff

./mach mochitest-browser browser/devtools/scratchpad/test

Browser Chrome Test Summary
 	Passed: 311
 	Failed: 0
 	Todo: 0
 
 *** End BrowserChrome Test Results ***
Attachment #8335117 - Attachment is obsolete: true
Attachment #8335672 - Flags: review?(bbenvie)
Hmm... the patch has some weird extra formatting in it. Take a look at the diff. Can you fix that?
(Assignee)

Comment 7

4 years ago
Should each file have it's own patch? I'm using git and the git-patch-to-hg-patch tool as mentioned on https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F but it only converts the first patch.
(Assignee)

Comment 8

4 years ago
Created attachment 8335764 [details] [diff] [review]
bug940016+test-v2.diff
Attachment #8335672 - Attachment is obsolete: true
Attachment #8335672 - Flags: review?(bbenvie)
Attachment #8335764 - Flags: review?(bbenvie)
(Assignee)

Comment 9

4 years ago
(In reply to Dan Koepke from comment #7)
> Should each file have it's own patch?...

I think I answered my own question. The most recent patch I attached has both files and the diff tool shows everything like it seems like it should.
Comment on attachment 8335764 [details] [diff] [review]
bug940016+test-v2.diff

Review of attachment 8335764 [details] [diff] [review]:
-----------------------------------------------------------------

That's better! Looks good to me!
Attachment #8335764 - Flags: review?(bbenvie) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/1638fd317c46
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js] → [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1638fd317c46
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js][fixed-in-fx-team] → [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.