Closed
Bug 940054
Opened 11 years ago
Closed 11 years ago
flash.sh should check its arguments
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 Sprint 5 - 11/22
People
(Reporter: jld, Assigned: jld)
Details
Attachments
(1 file)
Currently, there are places in flash.sh where an unrecognized argument is treated as the default. This combines especially badly with the earlier patch to enable FULLFLASH with an explicitly specified project (bug 927653), because now `./flash.sh --help` → `./flash.sh -f --help` → `./flash.sh -f` and then someone's phone gets unexpectedly bricked.
|
Assignee | |
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8334145 -
Flags: review?(dhylands)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8334145 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/B2G/pull/298
r+ with comments in the pull request addressed
Attachment #8334145 -
Flags: review?(dhylands) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Updated the PR; I made the unlock/nounlock thing a separate commit, but amended for the other change.
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Looks like Dave merged this and didn't update the bug.
Master: https://github.com/mozilla-b2g/B2G/commit/67341861bbc8672d31442732d9ef629bdcf05595
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 5 - 11/22
You need to log in
before you can comment on or make changes to this bug.
Description
•