940082 - [WebComponents] Find other hooks for current polyfill

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

We have been adding web components hooks into gaia using Lazy Loader. As we talk about starting to use real web components, we don't want these to get in the way of that. We need a way to inline these components, but still lazily load them as desired.

Comment 1

[Sam Joch [:samjoch]]

Hey, trying to find a way for inlining WC i come to that: https://github.com/mozilla-b2g/gaia/pull/13741, What do you think ?

Comment 2

[Kevin Grandon :kgrandon]

(In reply to Sam Joch [:samjoch] from comment #1)
> Hey, trying to find a way for inlining WC i come to that:
> https://github.com/mozilla-b2g/gaia/pull/13741, What do you think ?

Hi Sam. Great progress on the components! I'm not sure if you saw, but we have something similar in gaia today: https://github.com/mozilla-b2g/gaia/blob/master/build/webapp-optimize.js#L255

The point of this bug was to ensure that we do not collide with whatever solution we decide to implement in the future.

When looking at your diff - it looks like you have implemented inlining using handlebars.js is this correct? I need to refresh myself with the spec, but at first glance it doesn't look like the new components follow the specification - do they?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Kevin Grandon :kgrandon from comment #2)
> (In reply to Sam Joch [:samjoch] from comment #1)
> > Hey, trying to find a way for inlining WC i come to that:
> > https://github.com/mozilla-b2g/gaia/pull/13741, What do you think ?
> 
> Hi Sam. Great progress on the components! I'm not sure if you saw, but we
> have something similar in gaia today:
> https://github.com/mozilla-b2g/gaia/blob/master/build/webapp-optimize.js#L255
> 

Yeah he has seen it since I shown him :) 
> 
> When looking at your diff - it looks like you have implemented inlining
> using handlebars.js is this correct? I need to refresh myself with the spec,
> but at first glance it doesn't look like the new components follow the
> specification - do they?

While I agree this is not ideal, I think that does not matter yet. The main goal of his PR is to free Gaia developers to care about a special layout and all the various css specificity of building blocks. Once apps does not knows anything about layout/css we will be able to fix it, so this one is just a step forward.

While thinking about handlebar again, I remember that we have already a shared/js/template.js file, could we reuse that instead?

Comment 4

[Kevin Grandon :kgrandon]

Holding off on doing anything here until we have more  info on what we're doing with web components.