940090 - Upscaled snapshot is visible for a brief moment when you start a swipe gesture

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect, P2)

Description

[Reuben Morais [:reuben]]

After bug 836430 landed, you can see the upscaled snapshot for a brief moment as you start swiping.

Here's a video: https://dl.dropboxusercontent.com/u/10968786/swipe.mov

Comment 1

[Stephen A Pohl [:spohl]]

We clearly set the style.backgroundSize on the box element before assigning the snapshot to it, so I'm not quite sure why this happens. Also, I'm unable to reproduce myself. Is there anything special about your setup that could be the difference?

Comment 2

[Reuben Morais [:reuben]]

Probably, I tried on a new profile and couldn't reproduce :(
I have no idea how this could be profile specific.

Comment 3

[Reuben Morais [:reuben]]

FWIW, Christian can also reproduce this bug.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

I'm able to reproduce it too (not everytime but often). I added a breakpoint in _scaleSnapshot and it was taking the HTMLImageElement path, meaning that there's the load listener delay in properly scaling it. Is it expected to take that path for normal pages (I thought it would be only for image documents)?

Strangely, even before the load event, it appears that aSnapshot had the correct width/height, but I'm not so sure on that because I was using the debugger and it was acting strange and crashed after some more testing.

Comment 5

[Reuben Morais [:reuben]]

(In reply to :Felipe Gomes from comment #4)
> Is it expected to take that path for normal pages (I thought it would be only for image
> documents)?

I think it is, it's called from installPrevAndNextSnapshots and the saved snapshots are converted from Blobs to ImageElements there.

Comment 6

[Stephen A Pohl [:spohl]]

(In reply to Reuben Morais [:reuben] from comment #5)
> (In reply to :Felipe Gomes from comment #4)
> > Is it expected to take that path for normal pages (I thought it would be only for image
> > documents)?
> 
> I think it is, it's called from installPrevAndNextSnapshots and the saved
> snapshots are converted from Blobs to ImageElements there.

That's right, both previous and next snapshots are Blobs and go the path of the load listener for scaling. Not exactly sure what to do here...

Comment 7

[:Felipe Gomes (needinfo for replies!)]

What about caching the width and height values on the snapshot object instead of having to wait for the image to load?

Comment 8

[Stephen A Pohl [:spohl]]

The code in question here has been removed in bug 860493.