Closed Bug 940208 Opened 6 years ago Closed 5 years ago

Unbreak mingw after bug 938437

Categories

(Firefox Build System :: General, defect)

All
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: glandium, Assigned: jacek)

References

Details

Attachments

(1 file, 1 obsolete file)

I landed bug 938437 without mingw support deliberately. Adding such support shouldn't be hard but would require testing that i can't do.
Attached patch WIP (obsolete) — Splinter Review
When bug 938437, I created the attached patch to be able to build. This was just quick patch that I meant to go back to. 32-bit version could build with this, but failed in runtime, while win64 build failed with an error about badly sorted stuff. Since then, mingw build was broken (first by missing private destructor, now by sandbox code). I'm not sure when I will be able to work on this, so I'm attaching it to not get lost.
Attached patch patchSplinter Review
The attached version works (I couldn't really verify win64 because it crashes in js currently, but it gets past related code). Changes from WIP:

- ignore symbols containing refptr in the name. 64-bit builds have two additional symbols:

000000006cd18510 R .refptr.end_kPStaticModules_NSModule
000000006cd18ab0 R .refptr.start_kPStaticModules_NSModule

that seem to be safe to ignore.

- Don't use StaticXULComponents.ld on mingw
Assignee: nobody → jacek
Attachment #8460209 - Attachment is obsolete: true
Attachment #8475216 - Flags: review?(mh+mozilla)
Attachment #8475216 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/d504471b2b1e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.