940208 - Unbreak mingw after bug 938437

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I landed bug 938437 without mingw support deliberately. Adding such support shouldn't be hard but would require testing that i can't do.

Comment 1

[Jacek Caban]

Attachment: WIP

When bug 938437, I created the attached patch to be able to build. This was just quick patch that I meant to go back to. 32-bit version could build with this, but failed in runtime, while win64 build failed with an error about badly sorted stuff. Since then, mingw build was broken (first by missing private destructor, now by sandbox code). I'm not sure when I will be able to work on this, so I'm attaching it to not get lost.

Comment 2

[Jacek Caban]

Attachment: patch

The attached version works (I couldn't really verify win64 because it crashes in js currently, but it gets past related code). Changes from WIP:

- ignore symbols containing refptr in the name. 64-bit builds have two additional symbols:

000000006cd18510 R .refptr.end_kPStaticModules_NSModule
000000006cd18ab0 R .refptr.start_kPStaticModules_NSModule

that seem to be safe to ignore.

- Don't use StaticXULComponents.ld on mingw

Comment 3

[Jacek Caban]

Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d504471b2b1e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d504471b2b1e