940220 - Build bustage on VS2012+ with ICU enabled - "mozjs.dll failed to build: fatal error LNK1319: 136 mismatches detected"

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Xavier Fung]

Attachment: Build log

Using VS 2013 Ultimate and it fails to build mozjs.dll. Complete build log attached, and it seems to be ICU.

Comment 1

[Mike Hommey [:glandium]]

More ICU fun.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Exact same error on VS2012 for me

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: bug940220_vc12_icu

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8334909 [details] [diff] [review]
bug940220_vc12_icu

Review of attachment 8334909 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +1656,3 @@
>              dnl http://blogs.msdn.com/b/vcblog/archive/2013/09/11/introducing-gw-compiler-switch.aspx
> +            CFLAGS="$CFLAGS -FS -Gw -MD"
> +            CXXFLAGS="$CXXFLAGS -FS -Gw -MD"

That's not going to fly. We're also building with -MDd on debug builds.

Comment 5

[Masatoshi Kimura [:emk]]

Looks like $(RTL_FLAGS) should be passed to the icu build config.

Comment 6

[Masatoshi Kimura [:emk]]

Apparently this was fixed by the backout of bug 912371.

Comment 7

[u279076]

Xavier, can you confirm this is now fixed for you in Firefox 28?

Comment 8

[Xavier Fung]

This has been fixed. Thanks.

Comment 9

[u279076]

Thank you, Xavier.