940285 - Build failed with JS_ION off

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

gecko/js/src/jsinfer.cpp: In constructor 'js::types::CompilerConstraintList::CompilerConstraintList(js::jit::TempAllocator&)':
gecko/js/src/jsinfer.cpp:606: error: class 'js::types::CompilerConstraintList' does not have any field named 'constraints'
gecko/js/src/jsinfer.cpp:607: error: class 'js::types::CompilerConstraintList' does not have any field named 'frozenScripts'

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

And

gecko/js/src/jsgc.cpp: In static member function 'static void* js::gc::ArenaLists::refillFreeList(js::ThreadSafeContext*, js::gc::AllocKind)':
gecko/js/src/jsgc.cpp:1570: error: 'struct JSRuntime' has no member named 'workerThreadState'
gecko/js/src/jsgc.cpp:1572: error: 'struct JSRuntime' has no member named 'workerThreadState'
gecko/js/src/jsgc.cpp:1572: error: incomplete type 'js::WorkerThreadState' used in nested name specifier
gecko/js/src/jsgc.cpp: In constructor 'js::gc::AutoTraceSession::AutoTraceSession(JSRuntime*, js::HeapState)':
gecko/js/src/jsgc.cpp:4153: error: 'struct JSRuntime' has no member named 'workerThreadState'
gecko/js/src/jsgc.cpp: In destructor 'js::gc::AutoTraceSession::~AutoTraceSession()':
gecko/js/src/jsgc.cpp:4169: error: 'struct JSRuntime' has no member named 'workerThreadState'
gecko/js/src/jsgc.cpp:4173: error: 'struct JSRuntime' has no member named 'workerThreadState'
gecko/js/src/jsgc.cpp:4173: error: incomplete type 'js::WorkerThreadState' used in nested name specifier

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: patch

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f6d88f793a0

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6f6d88f793a0

Comment 5

[Daniel Holbert [:dholbert]]

This introduced this build-spew, for the init list being out of order now:
{
16:27.25 /scratch/work/builds/mozilla-central/mozilla-central-11-11-01.13-56/mozilla/js/src/jsinfer.cpp: In constructor ‘js::types::CompilerConstraintList::CompilerConstraintList(js::jit::TempAllocator&)’:
16:27.25 Warning: -Wreorder in /scratch/work/builds/mozilla-central/mozilla-central-11-11-01.13-56/mozilla/js/src/jsinfer.cpp: ‘js::types::CompilerConstraintList::failed_’ will be initialized after
16:27.25 /scratch/work/builds/mozilla-central/mozilla-central-11-11-01.13-56/mozilla/js/src/jsinfer.cpp:602:10: warning: ‘js::types::CompilerConstraintList::failed_’ will be initialized after [-Wreorder]
16:27.25      bool failed_;
16:27.25           ^
16:27.25 Warning: -Wreorder in /scratch/work/builds/mozilla-central/mozilla-central-11-11-01.13-56/mozilla/js/src/jsinfer.cpp:   ‘js::Vector<{anonymous}::CompilerConstraint*, 0ul, js::jit::IonAllocPolicy> js::types::CompilerConstraintList::constraints’
16:27.25 /scratch/work/builds/mozilla-central/mozilla-central-11-11-01.13-56/mozilla/js/src/jsinfer.cpp:595:58: warning:   ‘js::Vector<{anonymous}::CompilerConstraint*, 0ul, js::jit::IonAllocPolicy> js::types::CompilerConstraintList::constraints’ [-Wreorder]
16:27.25      Vector<CompilerConstraint *, 0, jit::IonAllocPolicy> constraints;
16:27.25                                                           ^
16:27.25 Warning: -Wreorder in /scratch/work/builds/mozilla-central/mozilla-central-11-11-01.13-56/mozilla/js/src/jsinfer.cpp:   when initialized here
16:27.25 /scratch/work/builds/mozilla-central/mozilla-central-11-11-01.13-56/mozilla/js/src/jsinfer.cpp:605:5: warning:   when initialized here [-Wreorder]
16:27.26      CompilerConstraintList(jit::TempAllocator &alloc)
16:27.26      ^
}

kanru, could you push a followup to reorder either the init list or the declarations of these variables in the class so that they match up?

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13c73af53854

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/13c73af53854