940297 - [Gaia] There is no 'absent' cardState in New IccManager's API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Edgar Chen [:edgar]]

In bug 814637, we introduce a new IccManager API for supporting multiple sim. In the new IccManager API, each MozIcc object represent a icc card, and only be created when the card is been detected. So there is no 'absent' in cardState any more, because when card is absent, MozIccManager even doesn't create a MozIcc object.

Comment 1

[Edgar Chen [:edgar]]

Attachment: WIP

Comment 2

[Edgar Chen [:edgar]]

Attachment: pull request #13891

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8335831 [details] [review]
pull request #13891

Hi Arthur, could you help to review setting and system part?
Hi Fernando, could you help to review the ftu part?

I have left some comments in github.

Thank you

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 8335831 [details] [review]
pull request #13891

FTU part looks nice, thanks

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8335831 [details] [review]
pull request #13891

r=me for the settings part with comment addressed. Thanks for the effort.

Flagging Alive for the system part.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/03a830c0e590de450caa45ea0597c8726bbe4234

Comment 7

[Jason Smith [:jsmith]]

Already in 1.3, so clearing nom.