940315 - Don't use a generic hash function to generate database filenames

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Jan Varga [:janv]]

This is a followup for bug 780408.

Comment 1

[Jan Varga [:janv]]

Vendo, want to help with this?

Comment 2

[Vendelin Ruzicka [:vendo]]

Attachment: bug940315-fix

I can try. Thanks.  The current hash function has been extracted in patch

Comment 3

[Jan Varga [:janv]]

Comment on attachment 8335569 [details] [diff] [review]
bug940315-fix

Review of attachment 8335569 [details] [diff] [review]:
-----------------------------------------------------------------

Please, double check that HashName() produces the same output as HashString(), thanks.

::: dom/indexedDB/OpenDatabaseHelper.cpp
@@ +66,5 @@
> +inline
> +uint32_t
> +RotateBitsLeft32(uint32_t value)
> +{
> +  uint8_t bits = 5;

hm, I don't think it's worth to have this as a constant, convert it to a parameter, please

@@ +77,5 @@
> +{
> +  const char16_t* str = aName.BeginReading();
> +  size_t length = aName.Length();
> +
> +  const uint32_t GoldenRatioU32 = 0x9E3779B9U;

rename it to kGoldenRatioU32 and move after  kSQLiteSchemaVersion, please

Comment 4

[Vendelin Ruzicka [:vendo]]

Attachment: bug940315-fix

updated and output checked by
printf("\n\n\ Names:   %d  =  %d \n", HashName(aName), HashString(aName));
./mach mochitest-plain dom/indexedDB/test/test_open_empty_db.html

Comment 5

[Jan Varga [:janv]]

Comment on attachment 8335899 [details] [diff] [review]
bug940315-fix

Review of attachment 8335899 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, r=me

Comment 6

[Jan Varga [:janv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a64e21f0e58

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a64e21f0e58