[Linux] New tab button: old assets used in Tab Bar while new assets are used in the Awesomebar

VERIFIED FIXED in Firefox 48

Status

()

Firefox
Theme
VERIFIED FIXED
4 years ago
2 years ago

People

(Reporter: Paul [pwd], Assigned: rakhisharma, Mentored)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 48
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 verified)

Details

(Whiteboard: [Australis:P5])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131119073913

Steps to reproduce:

The new tab button uses the old assets when in the tab bar but uses the new (winstripe) assets when in the awesome bar.
(Reporter)

Updated

4 years ago
Component: Untriaged → Theme

Comment 1

4 years ago
I don't think we have new icons for the tabstrip yet. Heck, we don't even have proper Linux icons yet - the icons we use right now are the Windows ones. But there are no more open bugs specifically about the icons on Linux, AFAIK. Stephen?
Blocks: 939862, 872617
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(shorlander)
Whiteboard: [Australis:P5]
Assignee: nobody → shorlander

Updated

4 years ago
Summary: Old assets used in Tab Bar while new assets are used in the Awesomebar → New tab button: old assets used in Tab Bar while new assets are used in the Awesomebar

Updated

4 years ago
Summary: New tab button: old assets used in Tab Bar while new assets are used in the Awesomebar → [Linux] New tab button: old assets used in Tab Bar while new assets are used in the Awesomebar
Could we just use the existing windows icon new tab button (both normal and inverted states) instead of using a linux specific icon?
(In reply to Brian Grinstead [:bgrins] from comment #2)
> Could we just use the existing windows icon new tab button (both normal and
> inverted states) instead of using a linux specific icon?

Yeah, we should just do that.
Assignee: shorlander → nobody
Flags: needinfo?(shorlander)

Comment 4

3 years ago
I have an SVG version at [0] if needed.

[0] : https://github.com/nt1m/FirefoxDevToolsSVG/blob/master/browser/

Comment 5

2 years ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> (In reply to Brian Grinstead [:bgrins] from comment #2)
> > Could we just use the existing windows icon new tab button (both normal and
> > inverted states) instead of using a linux specific icon?
> 
> Yeah, we should just do that.

Rakhi, can you look at doing this?
Mentor: gijskruitbosch+bugs@gmail.com
Flags: needinfo?(Rakhish1994)
(Assignee)

Comment 6

2 years ago
Yes sure! I will look at this :)
Flags: needinfo?(Rakhish1994)
(Assignee)

Comment 7

2 years ago
Created attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

Review commit: https://reviewboard.mozilla.org/r/44565/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44565/
Attachment #8738509 - Flags: review?(gijskruitbosch+bugs)

Updated

2 years ago
Attachment #8738509 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 8

2 years ago
Comment on attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

https://reviewboard.mozilla.org/r/44565/#review41277

I haven't tested this in-browser, but it looks great to me. One nit below, with that addressed, r=me !

::: browser/themes/linux/jar.mn:101
(Diff revision 1)
> +  skin/classic/browser/tabbrowser/newtab.svg          (tabbrowser/newtab.svg)
> +  skin/classic/browser/tabbrowser/newtab-inverted.svg (tabbrowser/newtab-inverted.svg)

Nit: can you move these two lines down to just before tab-active-middle.png so they're in alphabetical order?

Updated

2 years ago
Assignee: nobody → Rakhish1994
Status: NEW → ASSIGNED
(Assignee)

Comment 9

2 years ago
Comment on attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44565/diff/1-2/
(Assignee)

Comment 10

2 years ago
Comment on attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44565/diff/2-3/
Attachment #8738509 - Attachment description: MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r?gijs → MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs
(Assignee)

Comment 11

2 years ago
Comment on attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44565/diff/3-4/

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d34db6d094d8
https://hg.mozilla.org/mozilla-central/rev/e6d9e7a97079
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
I've managed to reproduce this bug on Nightly 28.0a1 (2013-11-19) on Linux, 64 Bit.

Bug is now verified as fixed on Latest Firefox Developer Edition 48.0a2 (2016-05-09)

Build ID: 20160509004024
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
OS: Linux 3.19.0-58-generic x86-64
QA Whiteboard: [bugday-20160511]

Updated

2 years ago
Status: RESOLVED → VERIFIED

Updated

2 years ago
status-firefox48: fixed → verified
You need to log in before you can comment on or make changes to this bug.