940332 - Win64 compiler warnings in BindingUtils.h (warning C4267: 'argument' : conversion from 'size_t' to XXX)

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect, P5)

Description

[Ryan VanderMeulen [:RyanVM]]

This is very frequently spammed in Win64 builds.

BindingUtils.h(895) : warning C4267: 'argument' : conversion from 'size_t' to 'uint32_t', possible loss of data

889 template<>
890 inline bool
891 EnumValueNotFound<true>(JSContext* cx, const jschar* chars, size_t length,
892                         const char* type, const char* sourceDescription)
893 {
894   NS_LossyConvertUTF16toASCII deflated(static_cast<const PRUnichar*>(chars),
895                                        length);
896   return ThrowErrorMessage(cx, MSG_INVALID_ENUM_VALUE, sourceDescription,
897                            deflated.get(), type);
898 }

BindingUtils.h(1566) : warning C4267: 'argument' : conversion from 'size_t' to 'nsAString_internal::size_type', possible loss of data

In ConvertJSValueToString:

1560  size_t len;
1561  const jschar *chars = JS_GetStringCharsZAndLength(cx, s, &len);
1562  if (!chars) {
1563    return false;
1564  }
1565
1566  result.SetData(chars, len);
1567  return true;

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.