Change top border for LWT restored windows on Windows 8

NEW
Unassigned

Status

()

5 years ago
a year ago

People

(Reporter: cwiiis, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P4][Australis:M-])

Attachments

(6 attachments)

(Reporter)

Description

5 years ago
Created attachment 8334529 [details]
Screenshot 2013-11-19 09.04.24.png

I'm not sure if this is Australis-specific, but I never had reason to use lightweight themes before. When applying a lightweight theme in Windows 8.1 in current Nightly, window borders don't inherit from the theme and look pretty bad. Screenshot attached.
Blocks: 939862, 732583
Even though I think so, let's check with Madhava if we should!
Flags: needinfo?(madhava)
Whiteboard: [Australis:P2]
We can't change the side borders, see bug 590945. It's a bug that there's no top border, though, we should render that ourselves. :-\
Flags: needinfo?(madhava)
They should, but having proper borders depends on fixing the bug Jared attached (bug 590945)
And my, do those screenshots look pretty in that bug! Shall we consider removing [Australis:M-] and put a solid prio on it?
(In reply to Mike de Boer [:mikedeboer] from comment #4)
> And my, do those screenshots look pretty in that bug! Shall we consider
> removing [Australis:M-] and put a solid prio on it?

Not a realistic priority at this point. Bug 672885 has more background and is a hard blocker for bug 590945.
Summary: Lightweight themes don't alter window borders → Add top border for LWT restored windows on Windows 8
Whiteboard: [Australis:P2] → [Australis:P3]
Whiteboard: [Australis:P3] → [Australis:P3][Australis:M-]
... the problem with this is that it's dependent on either bug 590945 or bug 578780, neither of which is making much progress. We could otherwise add a border but it'll color-mismatch with whatever the Win8 system color is.
Depends on: 578780
(In reply to :Gijs Kruitbosch from comment #6)
> ... the problem with this is that it's dependent on either bug 590945 or bug
> 578780, neither of which is making much progress. We could otherwise add a
> border but it'll color-mismatch with whatever the Win8 system color is.

Blake, do you have some kind of clever idea here?
Flags: needinfo?(bwinton)
Hmm.  Two thoughts/questions:
1) What happens if we replace the top 20 pixels of the image with a transparent colour?
2) What happens if we use some CSS to push the background down by 20 pixels?  (i.e. "background-position: center 20px")?
Flags: needinfo?(bwinton)
Huh, actually, looking at the image again, there's a black border on it. It's hard to tell because it's a window-only screencap, but the top line of that window is black(ish).

Chris, is this just too hard to see, or am I missing something, or...?
Flags: needinfo?(chrislord.net)
(Reporter)

Comment 10

5 years ago
(In reply to :Gijs Kruitbosch from comment #9)
> Huh, actually, looking at the image again, there's a black border on it.
> It's hard to tell because it's a window-only screencap, but the top line of
> that window is black(ish).
> 
> Chris, is this just too hard to see, or am I missing something, or...?

I see it too, but looking now, I don't see it - I see a line that's the primary colour but slightly darker. Perhaps it's black in that shot because the primary colour is quite dark - I'll attach another screenshot for reference.
Flags: needinfo?(chrislord.net)
(Reporter)

Comment 11

5 years ago
Created attachment 8364241 [details]
Screenshot 2014-01-23 09.40.39.png
(In reply to Chris Lord [:cwiiis] from comment #10)
> (In reply to :Gijs Kruitbosch from comment #9)
> > Huh, actually, looking at the image again, there's a black border on it.
> > It's hard to tell because it's a window-only screencap, but the top line of
> > that window is black(ish).
> > 
> > Chris, is this just too hard to see, or am I missing something, or...?
> 
> I see it too, but looking now, I don't see it - I see a line that's the
> primary colour but slightly darker. Perhaps it's black in that shot because
> the primary colour is quite dark - I'll attach another screenshot for
> reference.

Hrm, but that screenshot is without a lightweight theme, isn't it (you can tell because the navbar has a different background than the tabstrip)? That's just what Windows does to the window frame, that's not our fault. ;-)

I'm tempted to resolve WFM at this point. Chris, do you think that's accurate?
Flags: needinfo?(chrislord.net)

Comment 13

5 years ago
(In reply to :Gijs Kruitbosch from comment #6)
> ... the problem with this is that it's dependent on either bug 590945 or bug
> 578780, neither of which is making much progress. We could otherwise add a
> border but it'll color-mismatch with whatever the Win8 system color is.

rgba(0,0,0,0.1) ?
(In reply to Tim Nguyen [:ntim] from comment #13)
> (In reply to :Gijs Kruitbosch from comment #6)
> > ... the problem with this is that it's dependent on either bug 590945 or bug
> > 578780, neither of which is making much progress. We could otherwise add a
> > border but it'll color-mismatch with whatever the Win8 system color is.
> 
> rgba(0,0,0,0.1) ?

As noted in the later comments, there is already a border for lwthemes (the same one we use on aero on Win7), and win8 draws a correctly-colored border for non-lwthemes. I'm just waiting for confirmation from Chris that I'm not missing something, and then I think we should close this bug.
Whiteboard: [Australis:P3][Australis:M-] → [Australis:P4][Australis:M-]
(Reporter)

Comment 15

5 years ago
Created attachment 8373013 [details]
Screenshot 2014-02-09 14.59.14.png (with lightweight theme applied)

Ah, applying a lightweight theme does indeed add a weird black line at the top... I hadn't noticed this before, but it's more evident in this screenshot. I guess there is actually a problem here :/

(side-problem, my lightweight themes have spontaneously stopped working correctly :p)
Flags: needinfo?(chrislord.net)
(In reply to Chris Lord [:cwiiis] from comment #15)
> Created attachment 8373013 [details]
> Screenshot 2014-02-09 14.59.14.png (with lightweight theme applied)
> 
> Ah, applying a lightweight theme does indeed add a weird black line at the
> top... I hadn't noticed this before, but it's more evident in this
> screenshot. I guess there is actually a problem here :/
> 
> (side-problem, my lightweight themes have spontaneously stopped working
> correctly :p)

Can you reproduce that on a new profile, and if so, can you file a separate bug? Thank you!
Summary: Add top border for LWT restored windows on Windows 8 → Change top border for LWT restored windows on Windows 8
(Reporter)

Comment 17

5 years ago
(In reply to :Gijs Kruitbosch from comment #16)
> (In reply to Chris Lord [:cwiiis] from comment #15)
> > Created attachment 8373013 [details]
> > Screenshot 2014-02-09 14.59.14.png (with lightweight theme applied)
> > 
> > Ah, applying a lightweight theme does indeed add a weird black line at the
> > top... I hadn't noticed this before, but it's more evident in this
> > screenshot. I guess there is actually a problem here :/
> > 
> > (side-problem, my lightweight themes have spontaneously stopped working
> > correctly :p)
> 
> Can you reproduce that on a new profile, and if so, can you file a separate
> bug? Thank you!

It seems at some point those themes must've got corrupted, but the third theme I had installed (whose thumbnail still shows) worked fine, as do newly installed themes (so I can't really test this).

That black line exists when the theme renders correctly too.

Comment 18

4 years ago
Can't we just set chromemargin to an arbritary large size, inset the main content areas and toolbars, and let personas cover the whole window? In essence this means no window borders are drawn. It looks great at least on Windows 7

Comment 19

4 years ago
Created attachment 8398987 [details]
chromemargin-8.png

Arbitrary large chrome margin.

Comment 20

4 years ago
Created attachment 8398988 [details]
chromemargin-8-inset.png

Arbitrary large chrome margin, insetting the whole window via padding + repeated background

Comment 21

4 years ago
Created attachment 8398990 [details]
chromemargin-8-inset-tuned.png

Arbitrary large chrome margin, insetting the whole window via padding + repeated background + attempt to tune mask for the window buttons.

Note that the close button mask doesn't really fit, I tried shifting it around for a few times and I gave up.  Looks like the mask wasn't meant to cover the whole button originally.

The chromemargin is 0,7,7,7 and the padding on <window> is 0px 5px 5px. (It should have been 0 6px 6px had Firefox not opted for a 1px thinner margin similar to chrome).  The mask is offset by -3px to the right, and expanded by another few pixels to the right here.  This shouldn't be necessary if the mask (via -moz-appearance) was fixed.

The problem with this approach is that border-radius on the window doesn't work -- but this isn't an issue on Windows 8/8.1, only on Windows Vista/7.

And window resizing works! (No black flicker, just the 2px / 3px wide white strip which has existed for an eternity)
(In reply to henryfhchan from comment #21)
I think the main issue would still be bug 672885 as I think that happens when changing the chromemargin like you are. I've asked for clarification there (bug 672885 comment 104).

Yes, resizing works but the resizer only shows on a much narrower region which wouldn't be acceptable I think.

The issue with the window's border-radius, border in the corners of the top, and resizing are things which bug 590945 address.

You're free to make an extension which makes these changes for users who are fine with the tradeoffs but I don't think we would accept them in Firefox.
You need to log in before you can comment on or make changes to this bug.