Closed Bug 940479 Opened 7 years ago Closed 2 years ago

Australis - Menu bar aligned incorrectly with Windows 7 Aero Basic Theme

Categories

(Firefox :: Theme, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mkaply, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P4])

Attachments

(1 file)

Attached image Screenshot of problem.
With Australis, the Windows 7 Classic Theme places the menu bar too high.

We really should be leaving the titlebar there on Windows 7 Classic, the same way we did before Australis.
That looks like Aero basic, not the classic blue style.
Component: Widget: Win32 → Theme
Product: Core → Firefox
Can you clarify what you believe is incorrect about this? We show the menubar like this on all Windows themes and versions. I don't understand how this has anything to do with the Windows 7 Aero Basic theme, or why it should be different in this theme specifically.
Flags: needinfo?(mozilla)
It's too high. At the bare minimum, it should lower (vertically aligned with the close buttons on the right) and certainly below the perceived border..

All my other windows (including Firefox pre Australis) have a titlebar and the menu is below that.

People are going to be turning the menu on (especially in enterprise environments), so it should at least look usable.

As far as why it is different in this theme, without Aero, the window borders are more obvious, so it looks like the menu is sitting over the window border.
Flags: needinfo?(mozilla)
Whiteboard: [Australis:P3]
Summary: Australis - Menu bar aligned incorrectly with Windows 7 Classic Theme → Australis - Menu bar aligned incorrectly with Windows 7 Aero Basic Theme
Whiteboard: [Australis:P3] → [Australis:P4]
I would like to see this a higher priority.

To be blunt, I believe that lot of people (especially enterprises) are going to turn on the menu bar to avoid retraining costs and other questions associated with Australis.

It would be nice if we looked good in that case.
(In reply to Mike Kaply (:mkaply) from comment #4)
> I would like to see this a higher priority.
> 
> To be blunt, I believe that lot of people (especially enterprises) are going
> to turn on the menu bar to avoid retraining costs and other questions
> associated with Australis.
> 
> It would be nice if we looked good in that case.

This is hard to fix because of the TabsInTitlebar calculations in browser.js that mangling some margins in here would affect. I would take a patch but the effort/reward here isn't in the right place for us to make it a priority at the moment.
Whiteboard: [Australis:P4] → [Australis:P4][maybe-fix-on-aurora]
Whiteboard: [Australis:P4][maybe-fix-on-aurora] → [Australis:P4][can-fix-on-aurora]
Has this actually gotten worse since pre-Australis? Or about the same?
Much worse.

Pre Australis, if you turned on the menubar, you always got a titlebar as well (even if you were using an Windows 7 Aero theme that took away the titlebar when the Firefox button was displayed).

With Australis, there is no way to get a titlebar at all anymore.
(In reply to Mike Kaply (:mkaply) from comment #7)
> Much worse.
> 
> Pre Australis, if you turned on the menubar, you always got a titlebar as
> well (even if you were using an Windows 7 Aero theme that took away the
> titlebar when the Firefox button was displayed).
> 
> With Australis, there is no way to get a titlebar at all anymore.

There is, you should check out customize mode on a recent nightly/aurora.
> There is, you should check out customize mode on a recent nightly/aurora.

Nice. Then it should come on automatically when you turn the menu on (and stay on).

Also, another thing I just noticed is that if you turn on the menu (not titlebar) and restart the browser, the menu is positioned pretty good. If you then turn off the menu and turn it back on, it moves up too close to the top.

So there is code that positions it correctly somewhere.

Also, please tell me that titlebar thing is a preference somewhere so it can easily be turned on/off by companies that want to have it?
Whiteboard: [Australis:P4][can-fix-on-aurora] → [Australis:P4]
Duplicate of this bug: 1008649
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INACTIVE
Resolution: INACTIVE → WONTFIX
You need to log in before you can comment on or make changes to this bug.