Last Comment Bug 940479 - Australis - Menu bar aligned incorrectly with Windows 7 Aero Basic Theme
: Australis - Menu bar aligned incorrectly with Windows 7 Aero Basic Theme
Status: NEW
[Australis:P4]
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86_64 Windows 7
-- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
: Dão Gottwald [:dao]
Mentors:
: 1008649 (view as bug list)
Depends on:
Blocks: australis-merge
  Show dependency treegraph
 
Reported: 2013-11-19 09:54 PST by Mike Kaply [:mkaply]
Modified: 2014-05-11 16:04 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Screenshot of problem. (15.49 KB, image/png)
2013-11-19 09:54 PST, Mike Kaply [:mkaply]
no flags Details

Description User image Mike Kaply [:mkaply] 2013-11-19 09:54:05 PST
Created attachment 8334633 [details]
Screenshot of problem.

With Australis, the Windows 7 Classic Theme places the menu bar too high.

We really should be leaving the titlebar there on Windows 7 Classic, the same way we did before Australis.
Comment 1 User image Matthew N. [:MattN] (PM if requests are blocking you) 2013-11-19 13:33:11 PST
That looks like Aero basic, not the classic blue style.
Comment 2 User image :Gijs 2013-11-19 15:17:28 PST
Can you clarify what you believe is incorrect about this? We show the menubar like this on all Windows themes and versions. I don't understand how this has anything to do with the Windows 7 Aero Basic theme, or why it should be different in this theme specifically.
Comment 3 User image Mike Kaply [:mkaply] 2013-11-19 15:23:43 PST
It's too high. At the bare minimum, it should lower (vertically aligned with the close buttons on the right) and certainly below the perceived border..

All my other windows (including Firefox pre Australis) have a titlebar and the menu is below that.

People are going to be turning the menu on (especially in enterprise environments), so it should at least look usable.

As far as why it is different in this theme, without Aero, the window borders are more obvious, so it looks like the menu is sitting over the window border.
Comment 4 User image Mike Kaply [:mkaply] 2014-01-16 07:23:13 PST
I would like to see this a higher priority.

To be blunt, I believe that lot of people (especially enterprises) are going to turn on the menu bar to avoid retraining costs and other questions associated with Australis.

It would be nice if we looked good in that case.
Comment 5 User image :Gijs 2014-01-17 04:29:08 PST
(In reply to Mike Kaply (:mkaply) from comment #4)
> I would like to see this a higher priority.
> 
> To be blunt, I believe that lot of people (especially enterprises) are going
> to turn on the menu bar to avoid retraining costs and other questions
> associated with Australis.
> 
> It would be nice if we looked good in that case.

This is hard to fix because of the TabsInTitlebar calculations in browser.js that mangling some margins in here would affect. I would take a patch but the effort/reward here isn't in the right place for us to make it a priority at the moment.
Comment 6 User image Justin Dolske [:Dolske] 2014-03-06 13:10:46 PST
Has this actually gotten worse since pre-Australis? Or about the same?
Comment 7 User image Mike Kaply [:mkaply] 2014-03-06 13:15:15 PST
Much worse.

Pre Australis, if you turned on the menubar, you always got a titlebar as well (even if you were using an Windows 7 Aero theme that took away the titlebar when the Firefox button was displayed).

With Australis, there is no way to get a titlebar at all anymore.
Comment 8 User image :Gijs 2014-03-06 13:16:33 PST
(In reply to Mike Kaply (:mkaply) from comment #7)
> Much worse.
> 
> Pre Australis, if you turned on the menubar, you always got a titlebar as
> well (even if you were using an Windows 7 Aero theme that took away the
> titlebar when the Firefox button was displayed).
> 
> With Australis, there is no way to get a titlebar at all anymore.

There is, you should check out customize mode on a recent nightly/aurora.
Comment 9 User image Mike Kaply [:mkaply] 2014-03-06 13:22:16 PST
> There is, you should check out customize mode on a recent nightly/aurora.

Nice. Then it should come on automatically when you turn the menu on (and stay on).

Also, another thing I just noticed is that if you turn on the menu (not titlebar) and restart the browser, the menu is positioned pretty good. If you then turn off the menu and turn it back on, it moves up too close to the top.

So there is code that positions it correctly somewhere.

Also, please tell me that titlebar thing is a preference somewhere so it can easily be turned on/off by companies that want to have it?
Comment 10 User image :Gijs 2014-05-11 16:04:08 PDT
*** Bug 1008649 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.