94048 - [MAC CLASSIC] needs max-width on menuitems (was Add a new feature to tracate bookmarks when they are longer then a givin amount)

Status: VERIFIED FIXED

(Core :: XUL, enhancement)

Description

[Derek Schrock]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:0.9.3+) Gecko/20010806
BuildID:    2001080613

Would it be possible to and an item to preferences that would allow a user to
truncate bookmark names to a givin character limit when displayed in the
Bookmarks menu

This wouldnt change the name of the bookmark just the way it is displayed

If a bookmark is longer then x the bookmark name is displayed:
"Hello, this is my ho..."
In the Bookmarks menu

Comment 1

[Greg K.]

Confirming as an RFE. This will end up being very low priority, though, I'd wager. What 
you're really asking for is a preference for limiting the character length of menu items in 
any XPToolkit menu, of which Bookmarks is one. It's probably also easy to allow setting 
this length preference in any CSS unit.

It's funny that, on Mac, the trunaction method is different between the menubar 
Bookmarks menu (which uses the native menubar) and that on the Personal Toolbar, as 
the former uses middle truncation and the latter uses end truncation, probably Windows 
style. Oh, how I loathe inheriting bad Windows widget behavior. :-P Don't even get me 
started on text selection behavior in Mozilla. :-P

Changing component.

Comment 2

[Claudius Gayle]

this is an ancient duplicate. xpmenus are supposed to middle truncate and
anything else is suboptimal. You heard it here.

Comment 3

[Claudius Gayle]

when you change the component, change the QA and asignee especially on NEW bugs...

Comment 4

[John Morrison]

This would never be done as a pref (don't make me drag mpt over 
here to lecture you...). However, there should be a max-width on 
menuitems to prevent "out of control" menus, and there is such
a max-width, although not on Mac Classic skin (see below).

I can't find the exact dup. But here's where things stand, and I'm 
giving this to hewitt since the xpmenus can do either max-width or 
center cropping if directed to do so.

The win32/linux Classic skin, and the Modern skin both set a max-width,
but the Mac classic does not:

http://lxr.mozilla.org/seamonkey/source/themes/modern/global/menu.css#134
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/win/menu.css#31

The cropping being 'right' instead of 'center' is set here:

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/menu.xml

See also bug 67595 and pseudo-dupe bug 70943 (and possible dupe 98455).

Comment 5

[Joe Hewitt (gone)]

Mass reassigning some of my theme bugs to Shuehan.

Comment 6

[shliang]

giving to andrew

Comment 7

[andreww]

Attachment: settting max width in mac.

Comment 8

[andreww]

Attachment: better patch. earlier one did not take some menu states into account

Comment 9

[andreww]

seeking r, sr for patch now

Comment 10

[Simon Fraser [no longer active]]

Comment on attachment 52279 [details] [diff] [review]
better patch. earlier one did not take some menu states into account

sr=sfraser

Comment 11

[shliang]

r=shliang

Comment 12

[andreww]

fix checked into trunk.

Comment 13

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]