940586 - App tab glow overlaps the border between tabstrip and nav-bar

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screenshot from lmandel

We use the OSX native titlebar's bottom border as the separator between the tabstrip and the nav-bar. This is no good when it comes to layering, since the spec asks that the separator exist *on top* of background tabs and the app tab glow.

I think we should reconsider using the titlebar's bottom border, and perhaps draw our own border (like we do in private browsing mode) instead.

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

FWIW, I like the glow overlapping the border. In it's current form the glow is accentuated by breaking the border line. That's not to saw that maintaining a solid border at all times wouldn't work as well.

Comment 3

[:Gijs (he/him)]

Stephen, do we want to change this?

Comment 4

[Stephen Horlander [:shorlander]]

(In reply to :Gijs Kruitbosch from comment #3)
> Stephen, do we want to change this?

We should look into updating the styling of it at some point. But I think for now it's fine as is.

Comment 5

[:Gijs (he/him)]

(In reply to Stephen Horlander [:shorlander] from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > Stephen, do we want to change this?
> 
> We should look into updating the styling of it at some point. But I think
> for now it's fine as is.

Resolving per this comment, and we can reopen/reinvestigate if/when we update styling sometime in the future.