Closed
Bug 940692
Opened 11 years ago
Closed 11 years ago
Fix rooting hazard in CheckForOutdatedParent()
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
1.18 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
CheckForOutdatedParent() in nsINode.cpp holds a JSObject pointer over a call to GetScopeObject(), which can GC.
Here's a patch to root this instead.
Attachment #8334863 -
Flags: review?(bugs)
|
||
Updated•11 years ago
|
Attachment #8334863 -
Flags: review?(bugs) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Unfortunately this and the other bugs in https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=db0f8a5eeb33 have been backed out for causing rootanalysis assertions, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=30835010&tree=Mozilla-Inbound
Backout:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=05a0228c2caa
(For quick relanding, I recommend the third party qbackout extension and '--apply' mode)
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•