940693 - Australis menu disappears while submenu remains open, after clicking "x" next to "Contribute to Adblock Plus" in Adblock Plus submenu

Status: RESOLVED INVALID

(Firefox :: Menus, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Start Nightly, w/ fresh profile
 2. Get Adblock Plus and put its icon in Australis menu:
  a. Install Adblock Plus. (I'm using ver 2.4)
  b. Hit Australis menu button (upper-right corner) and then "Customize".
  c. Drag the Adblock Plus button on the Australis menu. Hit esc to leave customize mode.

 3. Open Australis menu, and hit Adblock Plus button.
 4. Click the "x" next to "Contribute to Adblock Plus"

EXPECTED RESULTS: The menu item disappears, and menus remain open.

ACTUAL RESULTS: The menu item disappears, and the ABP submenu remains open, *BUT* the Australis menu disappears. So, the submenu is left floating there, disembodied and broken-looking.

Comment 1

[Daniel Holbert [:dholbert]]

Note: The ABP submenu off of the "Tools" menu (in the normal menubar) does not have this problem.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast

Comment 3

[Ed Morley [:emorley]]

I saw this too, using Adblock plus dev version, on Win8.

Comment 4

[Wladimir Palant]

For some reason, whenever a button is clicked in the Adblock Plus menu the Australis menu closes - I assume that this is just how nested pop-ups work, I didn't make any difference if the click or mouseup event is canceled. So I decided to close the Adblock Plus menu when the buttons are clicked. This is suboptimal for the hide button but at least better than the behavior described here. https://hg.adblockplus.org/adblockplus/rev/e4bbaf48f134 contains this fix among others, it is part of the Adblock Plus 2.4.0.3737 development build.

Comment 5

[Wladimir Palant]

I guess that this bug should be resolved as WONTFIX - while there is some strange Gecko behavior here, this is really an edge case (buttons inside pop-ups aren't exactly commonplace, as are nested pop-ups).

Comment 6

[Dão Gottwald [:dao]]

This sounds like another manifestation of click tracking fragility, like bug 934532.

Comment 7

[Dão Gottwald [:dao]]

and bug 941109

Comment 8

[Wladimir Palant]

You are correct. Now that you've pointed me to the code responsible for this, it turns out that these two buttons simply need an noautoclose="true" attribute. This change is under review and should land in Adblock Plus development builds shortly.

Comment 9

[:Gijs (he/him)]

(In reply to Wladimir Palant from comment #5)
> I guess that this bug should be resolved as WONTFIX - while there is some
> strange Gecko behavior here, this is really an edge case (buttons inside
> pop-ups aren't exactly commonplace, as are nested pop-ups).

Yeah. We could adapt the code here to be even smarter about these edgecases, but I'm not sure this is worth it. Please reopen if you still have issues after adding the noautoclose attribute(s).

Comment 10

[Daniel Holbert [:dholbert]]

[Pretty sure this is technically INVALID, not WONTFIX -- it *is* a bug that we'd like to see fixed, but it's a bug in a 3rd-party piece of software (ABP)]