940696 - Ensure that Firefox OS brings up the number pad when a user focuses an <input type=number>

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jonathan Watt [:jwatt]]

With the patches for the various bugs to implement <input type=number> (bug 344616) it seems Firefox OS gets confused and opens the normal keyboard instead of the number pad when a number control is selected. See the "Gu" failures here:

https://tbpl.mozilla.org/?tree=Try&rev=326fa139fd34

This is perhaps not surprising since the content now looks like this:

  <input type=number>
    <!-- start of anonymous content -->
    <div>
      <input type=text>
      <div>
        <!-- some button elements -->
      </div>
    </div>
    <!-- end of anonymous content -->
  </input>

The anonymous <input type=text> takes focus for the number control, and presumably the logic that determines which keyboard in brought up depends on the focused element. I need to fix that logic so that it will correctly bring up the number pad.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

(In reply to Jonathan Watt [:jwatt] from comment #0)
> https://tbpl.mozilla.org/?tree=Try&rev=326fa139fd34

Since TBPL logs don't live forever, I should record the failures here for the record:

TEST-UNEXPECTED-FAIL | test_number_keyboard.py test_number_keyboard.TestNumberKeyboard.test_number_keyboard | MarionetteException: Please start a session
TEST-UNEXPECTED-FAIL | test_number_keyboard.py test_number_keyboard.TestNumberKeyboard.test_number_keyboard | AssertionError: 'en' != 'number'
raise TimeoutException(message)
TEST-UNEXPECTED-FAIL | test_settings_passcode.py test_settings_passcode.TestSettingsPasscode.test_set_passcode_by_settings | TimeoutException: Condition timed out
TEST-UNEXPECTED-FAIL | test_settings_passcode.py test_settings_passcode.TestSettingsPasscode.test_set_passcode_by_settings | MarionetteException: Please start a session
Return code: 2560
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34f95bb561db

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/34f95bb561db