Closed Bug 940717 Opened 6 years ago Closed 6 years ago

Unify the IsChromeURI functions we have in various places

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Attached patch IsChromeURI (obsolete) — Splinter Review
This blocks using UNIFIED_SOURCES in a few places.
Attachment #8334896 - Flags: review?(ehsan)
Blocks: 940719
Comment on attachment 8334896 [details] [diff] [review]
IsChromeURI

Review of attachment 8334896 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/xbl/src/nsXBLDocumentInfo.h
@@ +72,5 @@
>  #else
>  inline void AssertInCompilationScope() {}
>  #endif
>  
> +bool IsChromeURI(nsIURI* aURI);

This should not be needed, just #include URL.h in the cpp file.

::: dom/base/URL.cpp
@@ +67,5 @@
>    }
>  
>    nsCOMPtr<nsIURI> baseUri;
>    rv = ioService->NewURI(NS_ConvertUTF16toUTF8(aBase), nullptr, nullptr,
> +                         getter_AddRefs(baseUri));  if (NS_FAILED(rv)) {

Whoa!

::: dom/base/URL.h
@@ +132,5 @@
>  
>  }
>  }
>  
> +bool IsChromeURI(nsIURI* aURI);

Please put this in mozilla::dom.
Attachment #8334896 - Flags: review?(ehsan) → review-
Attachment #8334896 - Attachment is obsolete: true
Attachment #8335050 - Flags: review?(ehsan)
Attachment #8335050 - Flags: review?(ehsan) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/70b5b1f081f2
Assignee: nobody → bjacob
Target Milestone: --- → mozilla28
https://hg.mozilla.org/mozilla-central/rev/70b5b1f081f2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.