940717 - Unify the IsChromeURI functions we have in various places

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: IsChromeURI

This blocks using UNIFIED_SOURCES in a few places.

Comment 1

[(no longer active)]

Comment on attachment 8334896 [details] [diff] [review]
IsChromeURI

Review of attachment 8334896 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/xbl/src/nsXBLDocumentInfo.h
@@ +72,5 @@
>  #else
>  inline void AssertInCompilationScope() {}
>  #endif
>  
> +bool IsChromeURI(nsIURI* aURI);

This should not be needed, just #include URL.h in the cpp file.

::: dom/base/URL.cpp
@@ +67,5 @@
>    }
>  
>    nsCOMPtr<nsIURI> baseUri;
>    rv = ioService->NewURI(NS_ConvertUTF16toUTF8(aBase), nullptr, nullptr,
> +                         getter_AddRefs(baseUri));  if (NS_FAILED(rv)) {

Whoa!

::: dom/base/URL.h
@@ +132,5 @@
>  
>  }
>  }
>  
> +bool IsChromeURI(nsIURI* aURI);

Please put this in mozilla::dom.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: unify IsChromeURI functions

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/70b5b1f081f2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70b5b1f081f2