History objects should unconditionally throw if their inner is not current

RESOLVED FIXED in mozilla28

Status

()

defect
RESOLVED FIXED
6 years ago
2 months ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla28
x86
macOS
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Currently we do a subsumes check on the caller, which is more permissive than Hixie wants. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=23359
(Assignee)

Comment 3

6 years ago
Posted patch Tests. v1Splinter Review
Attachment #8334990 - Flags: review?(bzbarsky)
Comment on attachment 8334988 [details] [diff] [review]
Throw when accessing properties and methods on history objects in non-active documents. v1

r=me if we think this is web-compatible.
Attachment #8334988 - Flags: review?(bzbarsky) → review+
Comment on attachment 8334990 [details] [diff] [review]
Tests. v1

r=me, but did we not have any tests that verified the old same-origin behavior worked that need fixing?
Attachment #8334990 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

6 years ago
(In reply to Boris Zbarsky [:bz] from comment #5)
> Comment on attachment 8334990 [details] [diff] [review]
> Tests. v1
> 
> r=me, but did we not have any tests that verified the old same-origin
> behavior worked that need fixing?

It's what IE9 does, so probably.
https://hg.mozilla.org/mozilla-central/rev/f3cb53fd4a11
https://hg.mozilla.org/mozilla-central/rev/bc384ede1d1a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Comment 11

5 years ago
https://hg.mozilla.org/mozilla-central/rev/bc384ede1d1a
Flags: in-testsuite+
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.