940783 - History objects should unconditionally throw if their inner is not current

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

Currently we do a subsumes check on the caller, which is more permissive than Hixie wants. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=23359

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=8538c271cad7

Comment 2

[Bobby Holley (:bholley)]

Attachment: Throw when accessing properties and methods on history objects in non-active documents. v1

Comment 3

[Bobby Holley (:bholley)]

Attachment: Tests. v1

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8334988 [details] [diff] [review]
Throw when accessing properties and methods on history objects in non-active documents. v1

r=me if we think this is web-compatible.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8334990 [details] [diff] [review]
Tests. v1

r=me, but did we not have any tests that verified the old same-origin behavior worked that need fixing?

Comment 7

[Bobby Holley (:bholley)]

(In reply to Boris Zbarsky [:bz] from comment #5)
> Comment on attachment 8334990 [details] [diff] [review]
> Tests. v1
> 
> r=me, but did we not have any tests that verified the old same-origin
> behavior worked that need fixing?

It's what IE9 does, so probably.

Comment 8

[Bobby Holley (:bholley)]

Green try run in comment 1.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f3cb53fd4a11
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/bc384ede1d1a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3cb53fd4a11
https://hg.mozilla.org/mozilla-central/rev/bc384ede1d1a

Comment 10

[Kohei Yoshino]

Added to the site compat doc:
https://developer.mozilla.org/en-US/Firefox/Releases/28/Site_Compatibility

Comment 11

[Ioana (away)]

https://hg.mozilla.org/mozilla-central/rev/bc384ede1d1a