Closed
Bug 940808
Opened 11 years ago
Closed 11 years ago
Move first time search engine options loading from browser to FTU
Categories
(Firefox OS Graveyard :: Gaia::Browser, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
1.4 S1 (14feb)
People
(Reporter: qdot, Assigned: qdot)
Details
(Whiteboard: [ucid:browser104] [systemsfe] [1.4:p2])
Currently, we load search engines when the browser app is loaded for the first time. We need to move these to the system app
| Assignee | ||
Comment 1•11 years ago
|
||
The search engines are stores in an object store in the browser app indexeddb, so we'll also need to figure out where these go. A new datastore?
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → kyle
Comment 2•11 years ago
|
||
I think we talked about storing a small amount of data in plain json files before.
| Assignee | ||
Comment 3•11 years ago
|
||
mhenretty pointed out using https://developer.mozilla.org/en-US/docs/JavaScript_OS.File for possible storage of the json block
Comment 4•11 years ago
|
||
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #0)
> Currently, we load search engines when the browser app is loaded for the
> first time. We need to move these to the system app
The list of search engines should eventually be stored in Rocketbar settings, the design of which is still under discussion.
Why does this block bug 938171 ?
| Assignee | ||
Comment 5•11 years ago
|
||
I was just linking in everything around bookmarks to that bug, and it looked like a bookmark issue at the time. Unlinked.
No longer blocks: 938171
| Assignee | ||
Updated•11 years ago
|
Whiteboard: [ucid:browser104] [systemsfe] [1.4:p2]
| Assignee | ||
Comment 6•11 years ago
|
||
Currently blocked on discussions with product. ni?'ing pdol for fill-in once this is resolved.
Flags: needinfo?(pdolanjski)
Updated•11 years ago
|
Target Milestone: --- → 1.4 S1 (14feb)
Comment 7•11 years ago
|
||
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #6)
> Currently blocked on discussions with product. ni?'ing pdol for fill-in once
> this is resolved.
Kyle, we discussed this at length and in the release that includes Rocketbar, we won't offer the ability to configure other search engines (though it will likely be there in the future). Given that, what is the best course of action to deprecate this functionality for the time being?
Flags: needinfo?(pdolanjski) → needinfo?(kyle)
| Assignee | ||
Comment 8•11 years ago
|
||
Seeing this is a feature of the browser, which we'll now have around 'til 1.5, I can just leave it there and it'll be removed when the app itself is removed. Default search engine is stored in the browser's DB, so it's not affecting the rest of the system anyways. I'll go ahead and resolve this as wontfix now. If we want to actually remove this feature from the browser for 1.4, we should make another bug, but I'll leave that up to you.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(kyle)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•