940816 - Toggle-able toolbar button should have max-height

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screenshot

# env
- Windows 7 x86-64
- http://hg.mozilla.org/mozilla-central/rev/ba9ecdea3a90
- The right icon in screenshot uses the 18x18 px icon.

# Abstract
- If toolbar has a togglable toolbar button used for switching a sidebar, Australis toolbar height increases.
- I guess that we haven't changed the style for togglable toolbar button.

Comment 1

[:Gijs (he/him)]

Can you provide steps to reproduce, please? What add-on causes this problem?

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to :Gijs Kruitbosch from comment #1)
> Can you provide steps to reproduce, please? What add-on causes this problem?

This is reproduced on the testing branch of my add-on (https://github.com/saneyuki/LinkPlaces/tree/panel).
It uses the 18x18 toggled toolbar icon for Windows.

Comment 3

[Dão Gottwald [:dao]]

Can you post a screenshot showing how this looked before the Australis merge (e.g. on Aurora, Beta, Release or the Holly branch)?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Adding needinfo request in response to comment #3.

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

After make to use 16x16 toolbar icon by add-ons blog post (https://blog.mozilla.org/addons/2013/12/12/australis-for-add-on-developers-1/), this bug is not reproduce.